diff options
author | Loïc Blot <nerzhul@users.noreply.github.com> | 2017-04-21 23:40:48 +0200 |
---|---|---|
committer | GitHub <noreply@github.com> | 2017-04-21 23:40:48 +0200 |
commit | dc0e9097d3144a3dda81039f666ee43ba29cbc36 (patch) | |
tree | 25f9db4f6357826bfb5456a642b522bb0b235d6f /src/guiFileSelectMenu.h | |
parent | f151b2322003bbc89c2cd3c603ef1e1ab9d46439 (diff) | |
download | minetest-dc0e9097d3144a3dda81039f666ee43ba29cbc36.tar.gz minetest-dc0e9097d3144a3dda81039f666ee43ba29cbc36.tar.bz2 minetest-dc0e9097d3144a3dda81039f666ee43ba29cbc36.zip |
Fix various performance issues reported by cppcheck + code style (CI) (#5635)
* Make CI happy with code style on master
* guiFileSelectMenu: remove useless includes
* some performance fixes pointed by cppcheck
* remove some useless casts
* TextDest: remove unused setFormSpec function
Diffstat (limited to 'src/guiFileSelectMenu.h')
-rw-r--r-- | src/guiFileSelectMenu.h | 7 |
1 files changed, 2 insertions, 5 deletions
diff --git a/src/guiFileSelectMenu.h b/src/guiFileSelectMenu.h index e37d3d8df..a266cb399 100644 --- a/src/guiFileSelectMenu.h +++ b/src/guiFileSelectMenu.h @@ -32,8 +32,7 @@ class GUIFileSelectMenu: public GUIModalMenu public: GUIFileSelectMenu(gui::IGUIEnvironment* env, gui::IGUIElement* parent, s32 id, IMenuManager *menumgr, - std::string title, - std::string formid); + const std::string &title, const std::string &formid); ~GUIFileSelectMenu(); void removeChildren(); @@ -47,9 +46,7 @@ public: bool OnEvent(const SEvent& event); - bool isRunning() { - return m_running; - } + bool isRunning() const { return m_running; } void setTextDest(TextDest * dest) { m_text_dst = dest; |