diff options
| author | Loïc Blot <nerzhul@users.noreply.github.com> | 2017-04-21 23:40:48 +0200 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2017-04-21 23:40:48 +0200 |
| commit | dc0e9097d3144a3dda81039f666ee43ba29cbc36 (patch) | |
| tree | 25f9db4f6357826bfb5456a642b522bb0b235d6f /src/mesh.cpp | |
| parent | f151b2322003bbc89c2cd3c603ef1e1ab9d46439 (diff) | |
| download | minetest-dc0e9097d3144a3dda81039f666ee43ba29cbc36.tar.gz minetest-dc0e9097d3144a3dda81039f666ee43ba29cbc36.tar.bz2 minetest-dc0e9097d3144a3dda81039f666ee43ba29cbc36.zip | |
Fix various performance issues reported by cppcheck + code style (CI) (#5635)
* Make CI happy with code style on master
* guiFileSelectMenu: remove useless includes
* some performance fixes pointed by cppcheck
* remove some useless casts
* TextDest: remove unused setFormSpec function
Diffstat (limited to 'src/mesh.cpp')
| -rw-r--r-- | src/mesh.cpp | 10 |
1 files changed, 5 insertions, 5 deletions
diff --git a/src/mesh.cpp b/src/mesh.cpp index d776f6185..0a5b7fb6c 100644 --- a/src/mesh.cpp +++ b/src/mesh.cpp @@ -391,7 +391,7 @@ scene::IMeshBuffer* cloneMeshBuffer(scene::IMeshBuffer *mesh_buffer) switch (mesh_buffer->getVertexType()) { case video::EVT_STANDARD: { video::S3DVertex *v = (video::S3DVertex *) mesh_buffer->getVertices(); - u16 *indices = (u16*) mesh_buffer->getIndices(); + u16 *indices = mesh_buffer->getIndices(); scene::SMeshBuffer *temp_buf = new scene::SMeshBuffer(); temp_buf->append(v, mesh_buffer->getVertexCount(), indices, mesh_buffer->getIndexCount()); @@ -401,7 +401,7 @@ scene::IMeshBuffer* cloneMeshBuffer(scene::IMeshBuffer *mesh_buffer) case video::EVT_2TCOORDS: { video::S3DVertex2TCoords *v = (video::S3DVertex2TCoords *) mesh_buffer->getVertices(); - u16 *indices = (u16*) mesh_buffer->getIndices(); + u16 *indices = mesh_buffer->getIndices(); scene::SMeshBufferTangents *temp_buf = new scene::SMeshBufferTangents(); temp_buf->append(v, mesh_buffer->getVertexCount(), indices, mesh_buffer->getIndexCount()); @@ -410,7 +410,7 @@ scene::IMeshBuffer* cloneMeshBuffer(scene::IMeshBuffer *mesh_buffer) case video::EVT_TANGENTS: { video::S3DVertexTangents *v = (video::S3DVertexTangents *) mesh_buffer->getVertices(); - u16 *indices = (u16*) mesh_buffer->getIndices(); + u16 *indices = mesh_buffer->getIndices(); scene::SMeshBufferTangents *temp_buf = new scene::SMeshBufferTangents(); temp_buf->append(v, mesh_buffer->getVertexCount(), indices, mesh_buffer->getIndexCount()); @@ -447,7 +447,7 @@ scene::IMesh* convertNodeboxesToMesh(const std::vector<aabb3f> &boxes, buf->drop(); } - video::SColor c(255,255,255,255); + video::SColor c(255,255,255,255); for (std::vector<aabb3f>::const_iterator i = boxes.begin(); @@ -534,7 +534,7 @@ scene::IMesh* convertNodeboxesToMesh(const std::vector<aabb3f> &boxes, buf->append(vertices + j, 4, indices, 6); } } - return dst_mesh; + return dst_mesh; } struct vcache |