diff options
| author | Loïc Blot <nerzhul@users.noreply.github.com> | 2017-08-20 13:30:50 +0200 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2017-08-20 13:30:50 +0200 |
| commit | 1c1c97cbd1d7913ac12bf550ec02c97f843a0fd3 (patch) | |
| tree | 03dd0c39e323c7f0b1f06014ff30e74f429bfa01 /src/sound.h | |
| parent | 50669cd2822a11570ae462972194eeb2d585a8c1 (diff) | |
| download | minetest-1c1c97cbd1d7913ac12bf550ec02c97f843a0fd3.tar.gz minetest-1c1c97cbd1d7913ac12bf550ec02c97f843a0fd3.tar.bz2 minetest-1c1c97cbd1d7913ac12bf550ec02c97f843a0fd3.zip | |
Modernize source code: last part (#6285)
* Modernize source code: last par
* Use empty when needed
* Use emplace_back instead of push_back when needed
* For range-based loops
* Initializers fixes
* constructors, destructors default
* c++ C stl includes
Diffstat (limited to 'src/sound.h')
| -rw-r--r-- | src/sound.h | 7 |
1 files changed, 4 insertions, 3 deletions
diff --git a/src/sound.h b/src/sound.h index b9c847079..f52746369 100644 --- a/src/sound.h +++ b/src/sound.h @@ -39,7 +39,7 @@ struct SimpleSoundSpec { } - bool exists() const { return name != ""; } + bool exists() const { return !name.empty(); } std::string name = ""; float gain = 1.0f; @@ -50,7 +50,8 @@ struct SimpleSoundSpec class ISoundManager { public: - virtual ~ISoundManager() {} + virtual ~ISoundManager() = default; + // Multiple sounds can be loaded per name; when played, the sound // should be chosen randomly from alternatives // Return value determines success/failure @@ -80,7 +81,7 @@ public: { return playSound(spec.name, loop, spec.gain, spec.fade, spec.pitch); } - int playSoundAt(const SimpleSoundSpec &spec, bool loop, v3f pos) + int playSoundAt(const SimpleSoundSpec &spec, bool loop, const v3f &pos) { return playSoundAt(spec.name, loop, spec.gain, pos, spec.pitch); } |