diff options
| author | Loic Blot <loic.blot@unix-experience.fr> | 2015-02-15 17:30:38 +0100 |
|---|---|---|
| committer | Loic Blot <loic.blot@unix-experience.fr> | 2015-02-16 11:27:44 +0100 |
| commit | 7c8793cbea1ea83109b7d9d6974d3f6991efcec8 (patch) | |
| tree | 3a1c54acd3ee11fd73e11e81e2b83f917488a379 /src/util/numeric.h | |
| parent | ed04e8e9e407f0dd57fa83a9732b3a3968cb80e0 (diff) | |
| download | minetest-7c8793cbea1ea83109b7d9d6974d3f6991efcec8.tar.gz minetest-7c8793cbea1ea83109b7d9d6974d3f6991efcec8.tar.bz2 minetest-7c8793cbea1ea83109b7d9d6974d3f6991efcec8.zip | |
Performance Improvement: Use a cache which caches result for getFacePositions.
This greatly reduce the number of std::list generated by caching the result, which is always constant for each radius selected.
In the callgrind map, you will see original:
* 3.3M calls to std::list for 9700 calls to getFacePositions
In the modified version, you will see:
* 3.3K calls to std::list for 6900 call to getFacePositions
Callgrind map is here: #2321
it's a huge performance improvement to l_find_node_near
Diffstat (limited to 'src/util/numeric.h')
| -rw-r--r-- | src/util/numeric.h | 17 |
1 files changed, 15 insertions, 2 deletions
diff --git a/src/util/numeric.h b/src/util/numeric.h index db1eb003e..7fc3d2167 100644 --- a/src/util/numeric.h +++ b/src/util/numeric.h @@ -25,10 +25,23 @@ with this program; if not, write to the Free Software Foundation, Inc., #include "../irr_v3d.h" #include "../irr_aabb3d.h" #include <list> +#include <map> +#include <vector> #include <algorithm> -// Calculate the borders of a "d-radius" cube -void getFacePositions(std::list<v3s16> &list, u16 d); + +/* + * This class permits to cache getFacePosition call results + * This reduces CPU usage and vector calls + */ +class FacePositionCache +{ +public: + static std::vector<v3s16> getFacePositions(u16 d); +private: + static void generateFacePosition(u16 d); + static std::map<u16, std::vector<v3s16> > m_cache; +}; class IndentationRaiser { |