diff options
| author | Loïc Blot <nerzhul@users.noreply.github.com> | 2017-04-25 10:17:53 +0200 |
|---|---|---|
| committer | Loïc Blot <loic.blot@unix-experience.fr> | 2017-04-25 10:21:42 +0200 |
| commit | a7e131f53e211ffbe38d34d23b33e13cc401f013 (patch) | |
| tree | c615160a94df851752d62bfc2a4cf9f4d01f63ab /src/util | |
| parent | af9630962134346750f12c9f1856eae00e0dfe02 (diff) | |
| download | minetest-a7e131f53e211ffbe38d34d23b33e13cc401f013.tar.gz minetest-a7e131f53e211ffbe38d34d23b33e13cc401f013.tar.bz2 minetest-a7e131f53e211ffbe38d34d23b33e13cc401f013.zip | |
Fix various points reported by cppcheck (#5656)
* Fix various performance issues reported by cppcheck + code style (CI)
* Make CI happy with code style on master
* guiFileSelectMenu: remove useless includes
* some performance fixes pointed by cppcheck
* remove some useless casts
* TextDest: remove unused setFormSpec function
* Fix various iterator post-increment reported by cppcheck
Diffstat (limited to 'src/util')
| -rw-r--r-- | src/util/thread.h | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/src/util/thread.h b/src/util/thread.h index f54b8b48f..b96f302f6 100644 --- a/src/util/thread.h +++ b/src/util/thread.h @@ -83,8 +83,8 @@ public: GetRequest() {} ~GetRequest() {} - GetRequest(Key a_key) { - key = a_key; + GetRequest(const Key &a_key): key(a_key) + { } Key key; @@ -106,7 +106,7 @@ public: return m_queue.empty(); } - void add(Key key, Caller caller, CallerData callerdata, + void add(const Key &key, Caller caller, CallerData callerdata, ResultQueue<Key, T, Caller, CallerData> *dest) { typename std::deque<GetRequest<Key, T, Caller, CallerData> >::iterator i; |