summaryrefslogtreecommitdiff
path: root/src
diff options
context:
space:
mode:
authorShadowNinja <shadowninja@minetest.net>2013-12-18 18:17:26 -0500
committerShadowNinja <shadowninja@minetest.net>2013-12-18 18:18:43 -0500
commite1f9ba435f8c0cca90f2d3df36e9aa82763e1da0 (patch)
treee4d84dc22aff5c8048083cbfab1d7c97da958728 /src
parentba8fa0bd42b5a4a0e3658a5e784ee6a885dcc891 (diff)
downloadminetest-e1f9ba435f8c0cca90f2d3df36e9aa82763e1da0.tar.gz
minetest-e1f9ba435f8c0cca90f2d3df36e9aa82763e1da0.tar.bz2
minetest-e1f9ba435f8c0cca90f2d3df36e9aa82763e1da0.zip
Don't throw a error when writing JSON fails
Diffstat (limited to 'src')
-rw-r--r--src/script/common/c_content.cpp12
-rw-r--r--src/script/lua_api/l_util.cpp10
2 files changed, 14 insertions, 8 deletions
diff --git a/src/script/common/c_content.cpp b/src/script/common/c_content.cpp
index 8eb57ba41..cb5a92ae4 100644
--- a/src/script/common/c_content.cpp
+++ b/src/script/common/c_content.cpp
@@ -1106,26 +1106,26 @@ void get_json_value(lua_State *L, Json::Value &root, int index)
if (keytype == LUA_TNUMBER) {
lua_Number key = lua_tonumber(L, -1);
if (roottype != Json::nullValue && roottype != Json::arrayValue) {
- throw LuaError(NULL, "Can't mix array and object values in JSON");
+ throw SerializationError("Can't mix array and object values in JSON");
} else if (key < 1) {
- throw LuaError(NULL, "Can't use zero-based or negative indexes in JSON");
+ throw SerializationError("Can't use zero-based or negative indexes in JSON");
} else if (floor(key) != key) {
- throw LuaError(NULL, "Can't use indexes with a fractional part in JSON");
+ throw SerializationError("Can't use indexes with a fractional part in JSON");
}
root[(Json::ArrayIndex) key - 1] = value;
} else if (keytype == LUA_TSTRING) {
if (roottype != Json::nullValue && roottype != Json::objectValue) {
- throw LuaError(NULL, "Can't mix array and object values in JSON");
+ throw SerializationError("Can't mix array and object values in JSON");
}
root[lua_tostring(L, -1)] = value;
} else {
- throw LuaError(NULL, "Lua key to convert to JSON is not a string or number");
+ throw SerializationError("Lua key to convert to JSON is not a string or number");
}
}
} else if (type == LUA_TNIL) {
root = Json::nullValue;
} else {
- throw LuaError(NULL, "Can only store booleans, numbers, strings, objects, arrays, and null in JSON");
+ throw SerializationError("Can only store booleans, numbers, strings, objects, arrays, and null in JSON");
}
lua_pop(L, 1); // Pop value
}
diff --git a/src/script/lua_api/l_util.cpp b/src/script/lua_api/l_util.cpp
index 9fa6fcb77..f9ec94db4 100644
--- a/src/script/lua_api/l_util.cpp
+++ b/src/script/lua_api/l_util.cpp
@@ -179,7 +179,7 @@ int ModApiUtil::l_parse_json(lua_State *L)
return 1;
}
-// write_json(data[, styled]) -> string
+// write_json(data[, styled]) -> string or nil and error message
int ModApiUtil::l_write_json(lua_State *L)
{
NO_MAP_LOCK_REQUIRED;
@@ -191,7 +191,13 @@ int ModApiUtil::l_write_json(lua_State *L)
}
Json::Value root;
- get_json_value(L, root, 1);
+ try {
+ get_json_value(L, root, 1);
+ } catch (SerializationError &e) {
+ lua_pushnil(L);
+ lua_pushstring(L, e.what());
+ return 2;
+ }
std::string out;
if (styled) {