summaryrefslogtreecommitdiff
path: root/builtin/mainmenu/tab_multiplayer.lua
diff options
context:
space:
mode:
Diffstat (limited to 'builtin/mainmenu/tab_multiplayer.lua')
-rw-r--r--builtin/mainmenu/tab_multiplayer.lua284
1 files changed, 136 insertions, 148 deletions
diff --git a/builtin/mainmenu/tab_multiplayer.lua b/builtin/mainmenu/tab_multiplayer.lua
index 570259718..00150f26d 100644
--- a/builtin/mainmenu/tab_multiplayer.lua
+++ b/builtin/mainmenu/tab_multiplayer.lua
@@ -17,68 +17,71 @@
--------------------------------------------------------------------------------
local function get_formspec(tabview, name, tabdata)
- local render_details = core.is_yes(core.setting_getbool("public_serverlist"))
-
- local retval =
- "label[7.75,-0.15;" .. fgettext("Address / Port :") .. "]" ..
- "label[7.75,1.05;" .. fgettext("Name / Password :") .. "]" ..
- "field[8,0.75;3.4,0.5;te_address;;" ..
- core.formspec_escape(core.setting_get("address")) .. "]" ..
- "field[11.25,0.75;1.3,0.5;te_port;;" ..
- core.formspec_escape(core.setting_get("remote_port")) .. "]" ..
- "checkbox[0,4.85;cb_public_serverlist;" .. fgettext("Public Serverlist") .. ";" ..
- dump(core.setting_getbool("public_serverlist")) .. "]"
-
- if not core.setting_getbool("public_serverlist") then
- retval = retval ..
- "button[8,4.9;2,0.5;btn_delete_favorite;" .. fgettext("Delete") .. "]"
- end
+ -- Update the cached supported proto info,
+ -- it may have changed after a change by the settings menu.
+ common_update_cached_supp_proto()
+ local fav_selected = menudata.favorites[tabdata.fav_selected]
- retval = retval ..
- "button[10,4.9;2,0.5;btn_mp_connect;" .. fgettext("Connect") .. "]" ..
+ local retval =
+ "label[7.75,-0.15;" .. fgettext("Address / Port") .. "]" ..
+ "label[7.75,1.05;" .. fgettext("Name / Password") .. "]" ..
+ "field[8,0.75;3.3,0.5;te_address;;" ..
+ core.formspec_escape(core.setting_get("address")) .. "]" ..
+ "field[11.15,0.75;1.4,0.5;te_port;;" ..
+ core.formspec_escape(core.setting_get("remote_port")) .. "]" ..
+ "button[10.1,4.9;2,0.5;btn_mp_connect;" .. fgettext("Connect") .. "]" ..
"field[8,1.95;2.95,0.5;te_name;;" ..
- core.formspec_escape(core.setting_get("name")) .. "]" ..
+ core.formspec_escape(core.setting_get("name")) .. "]" ..
"pwdfield[10.78,1.95;1.77,0.5;te_pwd;]" ..
- "box[7.73,2.35;4.3,2.28;#999999]" ..
- "textarea[8.1,2.4;4.26,2.6;;"
-
- if tabdata.fav_selected ~= nil and
- menudata.favorites[tabdata.fav_selected] ~= nil and
- menudata.favorites[tabdata.fav_selected].description ~= nil then
- retval = retval ..
- core.formspec_escape(menudata.favorites[tabdata.fav_selected].description,true)
- end
+ "box[7.73,2.35;4.3,2.28;#999999]"
- retval = retval ..
- ";]"
+ if tabdata.fav_selected and fav_selected then
+ if gamedata.fav then
+ retval = retval .. "button[7.85,4.9;2.3,0.5;btn_delete_favorite;" ..
+ fgettext("Del. Favorite") .. "]"
+ end
+ if fav_selected.description then
+ retval = retval .. "textarea[8.1,2.4;4.26,2.6;;" ..
+ core.formspec_escape((gamedata.serverdescription or ""), true) .. ";]"
+ end
+ end
--favourites
- if render_details then
- retval = retval .. "tablecolumns[" ..
- "color,span=3;" ..
- "text,align=right;" .. -- clients
- "text,align=center,padding=0.25;" .. -- "/"
- "text,align=right,padding=0.25;" .. -- clients_max
- image_column(fgettext("Creative mode"), "creative") .. ",padding=1;" ..
- image_column(fgettext("Damage enabled"), "damage") .. ",padding=0.25;" ..
- image_column(fgettext("PvP enabled"), "pvp") .. ",padding=0.25;" ..
- "color,span=1;" ..
- "text,padding=1]" -- name
- else
- retval = retval .. "tablecolumns[text]"
- end
- retval = retval ..
- "table[-0.15,-0.1;7.75,5;favourites;"
+ retval = retval .. "tablecolumns[" ..
+ image_column(fgettext("Favorite"), "favorite") .. ";" ..
+ "color,span=3;" ..
+ "text,align=right;" .. -- clients
+ "text,align=center,padding=0.25;" .. -- "/"
+ "text,align=right,padding=0.25;" .. -- clients_max
+ image_column(fgettext("Creative mode"), "creative") .. ",padding=1;" ..
+ image_column(fgettext("Damage enabled"), "damage") .. ",padding=0.25;" ..
+ image_column(fgettext("PvP enabled"), "pvp") .. ",padding=0.25;" ..
+ "color,span=1;" ..
+ "text,padding=1]" ..
+ "table[-0.15,-0.1;7.75,5.5;favourites;"
if #menudata.favorites > 0 then
- retval = retval .. render_favorite(menudata.favorites[1],render_details)
-
- for i=2,#menudata.favorites,1 do
- retval = retval .. "," .. render_favorite(menudata.favorites[i],render_details)
+ local favs = core.get_favorites("local")
+ if #favs > 0 then
+ for i = 1, #favs do
+ for j = 1, #menudata.favorites do
+ if menudata.favorites[j].address == favs[i].address and
+ menudata.favorites[j].port == favs[i].port then
+ table.insert(menudata.favorites, i, table.remove(menudata.favorites, j))
+ end
+ end
+ if favs[i].address ~= menudata.favorites[i].address then
+ table.insert(menudata.favorites, i, favs[i])
+ end
+ end
+ end
+ retval = retval .. render_favorite(menudata.favorites[1], (#favs > 0))
+ for i = 2, #menudata.favorites do
+ retval = retval .. "," .. render_favorite(menudata.favorites[i], (i <= #favs))
end
end
- if tabdata.fav_selected ~= nil then
+ if tabdata.fav_selected then
retval = retval .. ";" .. tabdata.fav_selected .. "]"
else
retval = retval .. ";0]"
@@ -89,36 +92,38 @@ end
--------------------------------------------------------------------------------
local function main_button_handler(tabview, fields, name, tabdata)
- if fields["te_name"] ~= nil then
- gamedata.playername = fields["te_name"]
- core.setting_set("name", fields["te_name"])
+ if fields.te_name then
+ gamedata.playername = fields.te_name
+ core.setting_set("name", fields.te_name)
end
- if fields["favourites"] ~= nil then
- local event = core.explode_table_event(fields["favourites"])
+ if fields.favourites then
+ local event = core.explode_table_event(fields.favourites)
+ local fav = menudata.favorites[event.row]
+
if event.type == "DCL" then
if event.row <= #menudata.favorites then
- if not is_server_protocol_compat_or_error(menudata.favorites[event.row].proto_min,
- menudata.favorites[event.row].proto_max) then
+ if menudata.favorites_is_public and
+ not is_server_protocol_compat_or_error(
+ fav.proto_min, fav.proto_max) then
return true
end
- gamedata.address = menudata.favorites[event.row].address
- gamedata.port = menudata.favorites[event.row].port
- gamedata.playername = fields["te_name"]
- if fields["te_pwd"] ~= nil then
- gamedata.password = fields["te_pwd"]
- end
+
+ gamedata.address = fav.address
+ gamedata.port = fav.port
+ gamedata.playername = fields.te_name
gamedata.selected_world = 0
- if menudata.favorites ~= nil then
- gamedata.servername = menudata.favorites[event.row].name
- gamedata.serverdescription = menudata.favorites[event.row].description
+ if fields.te_pwd then
+ gamedata.password = fields.te_pwd
end
- if gamedata.address ~= nil and
- gamedata.port ~= nil then
- core.setting_set("address",gamedata.address)
- core.setting_set("remote_port",gamedata.port)
+ gamedata.servername = fav.name
+ gamedata.serverdescription = fav.description
+
+ if gamedata.address and gamedata.port then
+ core.setting_set("address", gamedata.address)
+ core.setting_set("remote_port", gamedata.port)
core.start()
end
end
@@ -127,101 +132,92 @@ local function main_button_handler(tabview, fields, name, tabdata)
if event.type == "CHG" then
if event.row <= #menudata.favorites then
- local address = menudata.favorites[event.row].address
- local port = menudata.favorites[event.row].port
-
- if address ~= nil and
- port ~= nil then
- core.setting_set("address",address)
- core.setting_set("remote_port",port)
+ gamedata.fav = false
+ local favs = core.get_favorites("local")
+ local address = fav.address
+ local port = fav.port
+ gamedata.serverdescription = fav.description
+
+ for i = 1, #favs do
+ if fav.address == favs[i].address and
+ fav.port == favs[i].port then
+ gamedata.fav = true
+ end
end
+ if address and port then
+ core.setting_set("address", address)
+ core.setting_set("remote_port", port)
+ end
tabdata.fav_selected = event.row
end
-
return true
end
end
- if fields["key_up"] ~= nil or
- fields["key_down"] ~= nil then
-
+ if fields.key_up or fields.key_down then
local fav_idx = core.get_table_index("favourites")
+ local fav = menudata.favorites[fav_idx]
- if fav_idx ~= nil then
- if fields["key_up"] ~= nil and fav_idx > 1 then
- fav_idx = fav_idx -1
- else if fields["key_down"] and fav_idx < #menudata.favorites then
- fav_idx = fav_idx +1
- end end
+ if fav_idx then
+ if fields.key_up and fav_idx > 1 then
+ fav_idx = fav_idx - 1
+ elseif fields.key_down and fav_idx < #menudata.favorites then
+ fav_idx = fav_idx + 1
+ end
else
fav_idx = 1
end
-
- if menudata.favorites == nil or
- menudata.favorites[fav_idx] == nil then
+
+ if not menudata.favorites or not fav then
tabdata.fav_selected = 0
return true
end
-
- local address = menudata.favorites[fav_idx].address
- local port = menudata.favorites[fav_idx].port
-
- if address ~= nil and
- port ~= nil then
- core.setting_set("address",address)
- core.setting_set("remote_port",port)
- end
-
- tabdata.fav_selected = fav_idx
- return true
- end
- if fields["cb_public_serverlist"] ~= nil then
- core.setting_set("public_serverlist", fields["cb_public_serverlist"])
+ local address = fav.address
+ local port = fav.port
- if core.setting_getbool("public_serverlist") then
- asyncOnlineFavourites()
- else
- menudata.favorites = core.get_favorites("local")
+ if address and port then
+ core.setting_set("address", address)
+ core.setting_set("remote_port", port)
end
- tabdata.fav_selected = nil
+
+ tabdata.fav_selected = fav_idx
return true
end
- if fields["btn_delete_favorite"] ~= nil then
+ if fields.btn_delete_favorite then
local current_favourite = core.get_table_index("favourites")
- if current_favourite == nil then return end
+ if not current_favourite then return end
+
core.delete_favorite(current_favourite)
- menudata.favorites = order_favorite_list(core.get_favorites())
+ asyncOnlineFavourites()
tabdata.fav_selected = nil
- core.setting_set("address","")
- core.setting_set("remote_port","30000")
-
+ core.setting_set("address", "")
+ core.setting_set("remote_port", "30000")
return true
end
- if (fields["btn_mp_connect"] ~= nil or
- fields["key_enter"] ~= nil) and fields["te_address"] ~= nil and
- fields["te_port"] ~= nil then
-
- gamedata.playername = fields["te_name"]
- gamedata.password = fields["te_pwd"]
- gamedata.address = fields["te_address"]
- gamedata.port = fields["te_port"]
-
+ if (fields.btn_mp_connect or fields.key_enter) and fields.te_address and fields.te_port then
+ gamedata.playername = fields.te_name
+ gamedata.password = fields.te_pwd
+ gamedata.address = fields.te_address
+ gamedata.port = fields.te_port
+ gamedata.selected_world = 0
local fav_idx = core.get_table_index("favourites")
+ local fav = menudata.favorites[fav_idx]
- if fav_idx ~= nil and fav_idx <= #menudata.favorites and
- menudata.favorites[fav_idx].address == fields["te_address"] and
- menudata.favorites[fav_idx].port == fields["te_port"] then
+ if fav_idx and fav_idx <= #menudata.favorites and
+ fav.address == fields.te_address and
+ fav.port == fields.te_port then
- gamedata.servername = menudata.favorites[fav_idx].name
- gamedata.serverdescription = menudata.favorites[fav_idx].description
+ gamedata.servername = fav.name
+ gamedata.serverdescription = fav.description
- if not is_server_protocol_compat_or_error(menudata.favorites[fav_idx].proto_min,
- menudata.favorites[fav_idx].proto_max)then
+ if menudata.favorites_is_public and
+ not is_server_protocol_compat_or_error(
+ fav.proto_min, fav.proto_max) then
return true
end
else
@@ -229,10 +225,8 @@ local function main_button_handler(tabview, fields, name, tabdata)
gamedata.serverdescription = ""
end
- gamedata.selected_world = 0
-
- core.setting_set("address", fields["te_address"])
- core.setting_set("remote_port",fields["te_port"])
+ core.setting_set("address", fields.te_address)
+ core.setting_set("remote_port", fields.te_port)
core.start()
return true
@@ -240,22 +234,16 @@ local function main_button_handler(tabview, fields, name, tabdata)
return false
end
-local function on_change(type,old_tab,new_tab)
- if type == "LEAVE" then
- return
- end
- if core.setting_getbool("public_serverlist") then
- asyncOnlineFavourites()
- else
- menudata.favorites = core.get_favorites("local")
- end
+local function on_change(type, old_tab, new_tab)
+ if type == "LEAVE" then return end
+ asyncOnlineFavourites()
end
--------------------------------------------------------------------------------
-tab_multiplayer = {
+return {
name = "multiplayer",
caption = fgettext("Client"),
cbf_formspec = get_formspec,
cbf_button_handler = main_button_handler,
on_change = on_change
- }
+}