summaryrefslogtreecommitdiff
path: root/src/gui
Commit message (Collapse)AuthorAge
* Formspecs: Close on metadata removal (#8348)SmallJoker2019-06-10
| | | | Formspecs will now close as soon the formspec string in the node metadata turns invalid.
* Do not drag-place stack into 'craftpreview' slot (#8514)SmallJoker2019-05-25
|
* Add IGUIScrollbar implementation with variable bar sizes (#8507)stujones112019-05-24
|
* Optimize string (mis)handling (#8128)Jozef Behran2019-05-18
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * Optimize statbar drawing The texture name of the statbar is a string passed by value. That slows down the client and creates litter in the heap as the content of the string is allocated there. Convert the offending parameter to a const reference to avoid the performance hit. * Optimize texture cache There is an unnecessary temporary created when the texture path is being generated. This slows down the cache each time a new texture is encountered and it needs to be loaded into the cache. Additionally, the heap litter created by this unnecessary temporary is particularly troublesome here as the following code then piles another string (the resulting full path of the texture) on top of it, followed by the texture itself, which both are quite long term objects as they are subsequently inserted into the cache where they can remain for quite a while (especially if the texture turns out to be a common one like dirt, grass or stone). Use std::string.append to get rid of the temporary which solves both issues (speed and heap fragmentation). * Optimize animations in client Each time an animated node is updated, an unnecessary copy of the texture name is created, littering the heap with lots of fragments. This can be specifically troublesome when looking at oceans or large lava lakes as both of these nodes are usually animated (the lava animation is pretty visible). Convert the parameter of GenericCAO::updateTextures to a const reference to get rid of the unnecessary copy. There is a comment stating "std::string copy is mandatory as mod can be a class member and there is a swap on those class members ... do NOT pass by reference", reinforcing the belief that the unnecessary copy is in fact necessary. However one of the first things the code of the method does is to assign the parameter to its class member, creating another copy. By rearranging the code a little bit this "another copy" can then be used by the subsequent code, getting rid of the need to pass the parameter by value and thus saving that copying effort. * Optimize chat console history handling The GUIChatConsole::replaceAndAddToHistory was getting the line to work on by value which turns out to be unnecessary. Get rid of that unnecessary copy by converting the parameter to a const reference. * Optimize gui texture setting The code used to set the texture for GUI components was getting the name of the texture by value, creating unnecessary performance bottleneck for mods/games with heavily textured GUIs. Get rid of the bottleneck by passing the texture name as a const reference. * Optimize sound playing code in GUIEngine The GUIEngine's code receives the specification of the sound to be played by value, which turns out to be most likely a mistake as the underlying sound manager interface receives the same thing by reference. Convert the offending parameter to a const reference to get rid of the rather bulky copying effort and the associated performance hit. * Silence CLANG TIDY warnings for unit tests Change "std::string" to "const std::string &" to avoid an unnecessary local value copy, silencing the CLANG TIDY process. * Optimize formspec handling The "formspec prepend" parameter was passed to the formspec handling code by value, creating unnecessary copy of std::string and slowing down the game if mods add things like textured backgrounds for the player inventory and/or other forms. Get rid of that performance bottleneck by converting the parameter to a const reference. * Optimize hotbar image handling The code that sets the background images for the hotbar is getting the name of the image by value, creating an unnecessary std::string copying effort. Fix that by converting the relevant parameters to const references. * Optimize inventory deserialization The inventory manager deserialization code gets the serialized version of the inventory by value, slowing the server and the client down when there are inventory updates. This can get particularly troublesome with pipeworks which adds nodes that can mess around with inventories automatically or with mods that have mobs with inventories that actively use them. * Optimize texture scaling cache There is an io::path parameter passed by value in the procedure used to add images converted from textures, leading to slowdown when the image is not yet created and the conversion is thus needed. The performance hit is quite significant as io::path is similar to std::string so convert the parameter to a const reference to get rid of it. * Optimize translation file loader Use "std::string::append" when calculating the final index for the translation table to avoid unnecessary temporary strings. This speeds the translation file loader up significantly as std::string uses heap allocation which tends to be rather slow. Additionally, the heap is no longer being littered by these unnecessary string temporaries, increasing performance of code that gets executed after the translation file loader finishes. * Optimize server map saving When the directory structure for the world data is created during server map saving, an unnecessary value passing of the directory name slows things down. Remove that overhead by converting the offending parameter to a const reference.
* Correct the checkbox selection box position (#8246)SmallJoker2019-04-27
| | | Remove m_btn_height dependency, replace with the text and checkbox size.
* Change pitch fly binding to 'P', add to change keys menu (#8314)rubenwardy2019-04-03
|
* Add newline before itemstring in item tooltip (#8213)Wuzzy2019-03-17
|
* LINT fixes since recent tooling updateLoïc Blot2019-03-14
|
* Drop GUIConfirmRegistration::m_address unused fieldLoïc Blot2019-03-12
|
* Confirm registration GUI: Remove positional strings to fix Windows bug (#8258)Paramat2019-03-10
| | | | Positional strings don't work on some Windows builds. Remove server address string, leave player name string present.
* Replace for loop with call to standard library function (#8194)Benjamin Lindley2019-03-05
| | | This loop makes multiple passes over m_stack (type std::list) in order to remove all elements with a specified value. Replacing the loop with a call to std::list::remove does the same job, but in only one pass.
* Fix coloured fog in main menu (#8181)random-geek2019-02-15
| | | Fixes #4727. The issue was due to the video driver fog colour never getting reset after closing the game.
* Don't append itemname to itemname in tooltip (#8176)Wuzzy2019-02-09
|
* Fix cloud color in loading screen and main menu (#8174)random-geek2019-02-04
|
* Update color of main menu clouds (#8172)random-geek2019-02-04
|
* Fix core.download_file() creating empty files on HTTP errorrubenwardy2019-02-03
|
* DragonFly BSD is somewhat identical to FreeBSD (#8159)Leonid Bobrov2019-02-03
|
* Android: Fix memory leak when displaying images in the mainmenu (#8011)rubenwardy2018-12-22
|
* Android: Move touchscreen rare controls inline with settings icon (#8006)stujones112018-12-20
|
* Fix Android build errors (caused by 5f1cd55)Juozas2018-12-03
| | | After commit 5f1cd55 touchscreengui.* files were pointing to old file locations
* Move client-specific files to 'src/client' (#7902)Quentin Bazin2018-11-28
| | | | | Update Android.mk Remove 'src/client' from include_directories
* Make non-formspec modal menus respect gui scale (#7850)stujones112018-11-26
|
* Client-side autojump. Remove Android-only stepheight autojump (#7228)Ben Deutsch2018-11-22
| | | | | | | | Works by detecting a collision while moving forward and then simulating a jump. If the simulated jump is more successful, an artificial jump key press is injected in the client. Includes setting and key change GUI element for enabling and disabling this feature.
* Android: Improve UI scaling on smaller high-density displays (#7834)stujones112018-11-18
| | | | * Android: Improve UI scaling on smaller high-density displays
* Minor changes for IrrLicht 1.9 supportnumber Zero2018-11-11
|
* Drop .NET-specific workaround: _IRR_IMPLEMENT_MANAGED_MARSHALLING_BUGFIXnumber Zero2018-11-11
|
* Formspecs: Fix text clipped by scrollbars (#7816)random-geek2018-11-06
|
* Remove un-needed header inclusionstujones112018-10-29
|
* Move touchscreen input handling to base GUIModalMenu classstujones112018-10-29
|
* Android buttons: Inset 'rare controls', inset and resize 'gear icon' (#7792)Paramat2018-10-19
| | | | | Previously these were both inconsistently close to the screen edge. 'gear icon' has been enlarged to match the width of 'zoom' and 'aux' buttons.
* Formspecs: Fix invalid background warningrubenwardy2018-08-20
| | | | | Clipped backgrounds are still valid with no size[] tag, as they will apply themselves correctly to any size Fixes #7197
* Formspecs: Fix missing trim() when checking for no_prepend[]rubenwardy2018-08-15
|
* Formspecs: Add tooltip element for arearubenwardy2018-08-05
|
* guiFormspecMenu: Allow fraction values for container[] (#7497)SmallJoker2018-08-04
| | | Switch spacing and pos_offset to v2f32 for percision, add helper function
* Allow enter to select items from combobox's list (#7351)Rob Blanckaert2018-07-28
|
* Add a MSVC / Windows compatible snprintf function (#7353)nOOb31672018-07-22
| | | Use sizeof where applicable for mt_snprintf
* Android: Add 'aux' button (#7477)Muhammad Rifqi Priyo Susanto2018-07-10
| | | | | Add 'aux' button. Use joystick to trigger 'aux' button when forward and out of main circle, by enabling 'virtual_joystick_triggers_aux' setting.
* Fix memory leak in guiConfirmRegistrationHybridDog2018-07-06
|
* Android: Resize jump and sneak buttons' touch target (#7498)Muhammad Rifqi Priyo Susanto2018-06-30
|
* Fix more GCC 8.1 warnings ↵Loïc Blot2018-05-28
| | | | | | | | | |   1   master  Fix 3 warnings reported by GCC 8.1 of the following type ```src/client/gameui.cpp:191:43: warning: « void* memset(void*, int, size_t) » effacement d'un objet du type non trivial « struct GameUI::Flags »; use assignment or value-initialization instead [-Wclass-memaccess] memset(&m_flags, 0, sizeof(GameUI::Flags)); ```
* Don't show Android edit dialog when tapping read-only field (#7337)Muhammad Rifqi Priyo Susanto2018-05-15
| | | | | * Don't show Android edit dialog when tapping read-only field From Lua API, "If the name is empty the textarea is readonly."
* Fix crash guiConfirmRegistration quit menu (#7313)Vincent Glize2018-05-10
|
* Formspecs: Allow setting alpha value for the box[] elementThomas--S2018-04-23
|
* Android: Modify touch screen GUI's buttons (#7240)Muhammad Rifqi Priyo Susanto2018-04-18
| | | | | | | * Android: Add zoom, minimap, and toggle chat button Zoom button is put above jump button. Minimap and toggle chat button are put in settings bar. * Jump button is rotated down button * Move three buttons on the right screen higher
* Android: Replace movement buttons with joystick (#7126)Muhammad Rifqi Priyo Susanto2018-04-10
| | | | | | | | | | | | | | | | | * Android: Replace movement buttons with joystick Replace movement control buttons (arrows at bottom left screen) with virtual joystick. Joystick has 8 directions (same as keyboard). Basically, just map it to keyboard input. Joystick applies only on left 1/3 of screen. Joystick's position can be fixed by enabling fixed_virtual_joystick setting. Three new images: (1) placeholder joystick, (2) joystick container (background), and (3) joystick cursor. Remove unused images: movement control buttons (*_arrow.png). New data type: touch_gui_joystick_move_id Joystick's fixed position is spaced one button size from bottom and from left of screen. Remove unused variable: m_joystick_downlocation
* Selected ItemStack: Reduce black magic (#6520)SmallJoker2018-04-03
| | | | * Selected ItemStack: Reduce black magic Better button variable value naming
* Formspecs: Use mouse wheel to pick up and deposit single itemsyou2018-04-02
|
* LINT: add clang-tidy step (#6295)Loïc Blot2018-04-01
| | | | | | | | | * Implement new travis clang-tidy build step * This step enable some rules and enforce one rule as error * This permits to have some C++ quality rules based on clang & clang contributor guidelines * Fix clang-tidy reported problems on push_back -> emplace_back
* Add formspec theming using prepended stringsAndrew Ward2018-03-28
|
* Guard sound manager initialization with "enable_sound" (#7167)nOOb31672018-03-26
|