| Commit message (Collapse) | Author | Age |
|
|
|
|
|
|
| |
* Promote performance-type-promotion-in-math-fn as a coding error
* Promote performance-faster-string-find too (which is not problematic currently)
* Same for performance-implicit-cast-in-loop
* Fix remaining tidy points
|
|
|
|
| |
* Huge LBM lookup performance improvement on mapblock loading
|
|
|
|
|
|
|
|
| |
* src/sky.cpp 146 warn V519 The 'suncolor_f.r' variable is assigned values twice successively. Perhaps this is a mistake. Check lines: 142, 146.
* src/sky.cpp 147 warn V519 The 'suncolor_f.g' variable is assigned values twice successively. Perhaps this is a mistake. Check lines: 143, 147.
* src/sky.cpp 148 warn V519 The 'suncolor_f.b' variable is assigned values twice successively. Perhaps this is a mistake. Check lines: 144, 148.
* src/threading/thread.cpp 63 err V730 Not all members of a class are initialized inside the constructor. Consider inspecting: m_thread_obj.
* src/server.cpp 3243 err V595 The 'log' pointer was utilized before it was verified against nullptr. Check lines: 3243, 3258.
|
| |
|
|
|
|
| |
* Use constexpr + unroll some calculations to cache definitively some calculations
* Unroll some calls in collision code & use a constref instead of a copy in one occurence
|
|
|
|
|
|
| |
Based on https://travis-ci.org/minetest/minetest/jobs/361810382 output
Also fix 2 missing copyright notices
|
|
|
|
| |
Based on https://travis-ci.org/minetest/minetest/jobs/361714253 output
|
| |
|
|
|
|
| |
* Selected ItemStack: Reduce black magic
Better button variable value naming
|
|
|
|
|
|
| |
* Add IrrLicht type aliases
* Add hash for IrrLicht vector
* Add object map
|
|
|
|
|
|
|
|
|
|
|
| |
* Fix many issues reported by clang-tidy
We have many issues in code related to some performance to float <-> double.
Clang-tidy reported it in performance-type-promotion-in-math-fn
I fixed many of them. It's not ready for a promote to blocking
Also fix some value which should be const-ref
|
| |
|
| |
|
| |
|
| |
|
|
|
|
|
|
|
|
|
| |
* Implement new travis clang-tidy build step
* This step enable some rules and enforce one rule as error
* This permits to have some C++ quality rules based on clang & clang contributor guidelines
* Fix clang-tidy reported problems on push_back -> emplace_back
|
|
|
|
| |
Allow changing the velocity of objects relatively to their current velocity
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Drop EventManager from GameDef & do some client cleanups
* EventManager is only used by Client. Don't expose it on Server & GameDef for nothing
* Drop Client::event() in favor of direct calls to getEventManager
* Cleanup some event put from new + put to put(new)
* MtEvent: add Type(u8) enum
* This will enhance event performance & ensure stricter type
* Drop MtEvent::checkIs (unused)
* clang-tidy reported fixes
* Code style
* Move event_manager.h to the client directory as it's only used by client
Add EventManager unittests + switch to unordered_map as order is not important here
Drop a unused function
|
|
|
|
|
|
|
| |
* Mgcarpathian: ZYX -> ZXY mapgen loop optimisation.
* 'pow(n, 3)' to 'n * n * n' type optimisations.
* fabs() -> std::fabs().
|
|
|
|
| |
Ensure singleton is reset
|
| |
|
| |
|
|
|
|
|
| |
minetest/src/script/cpp_api/s_player.h:27:1: warning: struct 'PlayerHPChangeReason' was previously declared as a class [-Wmismatched-tags]
struct PlayerHPChangeReason;
|
|
|
|
| |
Also switch some of them which are reported by clang-tidy
|
| |
|
| |
|
| |
|
| |
|
|
|
| |
The xxf86vm needs to be removed from Apple builds to avoid CMake Error XXF86VM_LIBRARY is NOTFOUND
|
| |
|
| |
|
|
|
|
|
|
|
|
|
|
| |
* Cleanup sound manager client
* Use some const refs
* Use auto on iterators
* Drop unused parameters
* Move sound_openal.* to client folder
* Move sound.cpp + OnDemandSoundFetcher to client/ folder + reorganize includes properly
|
|
|
|
| |
* Print the mod loading time
|
|
|
|
|
|
|
|
|
|
|
| |
```
src/client/joystick_controller.h:85:2: warning: duplicate 'virtual' declaration specifier [-Wduplicate-decl-specifier]
virtual bool isTriggered(const irr::SEvent::SJoystickEvent &ev) const;
/usr/bin/../lib64/gcc/x86_64-pc-linux-gnu/7.3.1/../../../../include/c++/7.3.1/ext/new_allocator.h:140:22: warning: destructor called on non-final 'JoystickAxisCmb' that has virtual functions but non-virtual destructor [-Wdelete-non-virtual-dtor]
destroy(_Up* __p) { __p->~_Up(); }
/usr/bin/../lib64/gcc/x86_64-pc-linux-gnu/7.3.1/../../../../include/c++/7.3.1/ext/new_allocator.h:140:22: warning: destructor called on non-final 'JoystickButtonCmb' that has virtual functions but non-virtual destructor [-Wdelete-non-virtual-dtor]
destroy(_Up* __p) { __p->~_Up(); }
```
|
|
|
|
| |
* Global initialization of sound using SoundManagerGlobal
|
|
|
|
|
|
| |
* Update MeshCollector
* Simplify MeshCollector
|
| |
|
| |
|
|
|
|
| |
in test_servermodmanager.cpp
|
| |
|
|
|
|
| |
for ServerEnv itself
|
| |
|
|
|
|
|
|
|
|
| |
* Server: delegate mod management & config to ServerModConfiguration (rename it to ServerModManager)
* Use c++11 range based loops
* Add unittests + experimental/default mod as a test case to permit testing mod loading in future tests
|
| |
|
| |
|
|
|
|
| |
Change name of default biome to a more suitable lowercase 'default'.
|
|
|
|
| |
* Add voxelarea unittests
|
| |
|
|
|
|
|
|
| |
guiConfirmRegistration
* Also fix variable name overloading in guiConfirmRegistration
|