From 365e4ae0faee79ff7b62396f27667e8315ba94d4 Mon Sep 17 00:00:00 2001 From: Loic Blot Date: Thu, 5 Mar 2015 10:43:08 +0100 Subject: Performance improvement: Use std::list instead of std::vector for request_media, Server::getModNames, Environment::m_simple_objects. * Also remove unused Server::m_modspaths --- src/environment.cpp | 12 +++++------- 1 file changed, 5 insertions(+), 7 deletions(-) (limited to 'src/environment.cpp') diff --git a/src/environment.cpp b/src/environment.cpp index 6cabc0dbc..b1372431f 100644 --- a/src/environment.cpp +++ b/src/environment.cpp @@ -2025,9 +2025,8 @@ ClientEnvironment::~ClientEnvironment() delete i->second; } - for(std::list::iterator - i = m_simple_objects.begin(); i != m_simple_objects.end(); ++i) - { + for(std::vector::iterator + i = m_simple_objects.begin(); i != m_simple_objects.end(); ++i) { delete *i; } @@ -2382,11 +2381,10 @@ void ClientEnvironment::step(float dtime) Step and handle simple objects */ g_profiler->avg("CEnv: num of simple objects", m_simple_objects.size()); - for(std::list::iterator - i = m_simple_objects.begin(); i != m_simple_objects.end();) - { + for(std::vector::iterator + i = m_simple_objects.begin(); i != m_simple_objects.end();) { ClientSimpleObject *simple = *i; - std::list::iterator cur = i; + std::vector::iterator cur = i; ++i; simple->step(dtime); if(simple->m_to_be_removed){ -- cgit v1.2.3