From 5b237b4d94cc3fa4a95f951654dfbe37dcf2e2f9 Mon Sep 17 00:00:00 2001 From: kwolekr Date: Sun, 3 May 2015 22:05:24 -0400 Subject: ObjDefManager: Set replacement object's handle info after calling set() Make gamedef optional when constructing an ObjDefManager Add note about object ownership --- src/mapgen.h | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) (limited to 'src/mapgen.h') diff --git a/src/mapgen.h b/src/mapgen.h index ee7e8227e..5be004e9f 100644 --- a/src/mapgen.h +++ b/src/mapgen.h @@ -206,12 +206,15 @@ public: std::string name; }; +// WARNING: Ownership of ObjDefs is transferred to the ObjDefManager it is +// added/set to. Note that ObjDefs managed by ObjDefManager are NOT refcounted, +// so the same ObjDef instance must not be referenced multiple class ObjDefManager { public: ObjDefManager(IGameDef *gamedef, ObjDefType type); virtual ~ObjDefManager(); - virtual const char *getObjectTitle() const = 0; + virtual const char *getObjectTitle() const { return "ObjDef"; } virtual void clear(); virtual ObjDef *getByName(const std::string &name) const; -- cgit v1.2.3