From 365e4ae0faee79ff7b62396f27667e8315ba94d4 Mon Sep 17 00:00:00 2001 From: Loic Blot Date: Thu, 5 Mar 2015 10:43:08 +0100 Subject: Performance improvement: Use std::list instead of std::vector for request_media, Server::getModNames, Environment::m_simple_objects. * Also remove unused Server::m_modspaths --- src/script/lua_api/l_server.cpp | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) (limited to 'src/script/lua_api') diff --git a/src/script/lua_api/l_server.cpp b/src/script/lua_api/l_server.cpp index 8d7f6512e..16331a933 100644 --- a/src/script/lua_api/l_server.cpp +++ b/src/script/lua_api/l_server.cpp @@ -367,13 +367,14 @@ int ModApiServer::l_get_modnames(lua_State *L) NO_MAP_LOCK_REQUIRED; // Get a list of mods - std::list mods_unsorted, mods_sorted; + std::vector mods_unsorted; + std::list mods_sorted; getServer(L)->getModNames(mods_unsorted); // Take unsorted items from mods_unsorted and sort them into // mods_sorted; not great performance but the number of mods on a // server will likely be small. - for(std::list::iterator i = mods_unsorted.begin(); + for(std::vector::iterator i = mods_unsorted.begin(); i != mods_unsorted.end(); ++i) { bool added = false; for(std::list::iterator x = mods_sorted.begin(); -- cgit v1.2.3