From f68dcd083a1bfe59d77afac300adbc29a7c70138 Mon Sep 17 00:00:00 2001 From: "Y. Wang" Date: Wed, 1 Oct 2025 22:45:06 +0000 Subject: Deprecate poconvert --- advtrains/init.lua | 4 ++-- advtrains/poconvert.lua | 13 +++++++++++++ 2 files changed, 15 insertions(+), 2 deletions(-) (limited to 'advtrains') diff --git a/advtrains/init.lua b/advtrains/init.lua index 25098d9..f99de26 100644 --- a/advtrains/init.lua +++ b/advtrains/init.lua @@ -52,9 +52,9 @@ advtrains.TRAIN_MAX_WAGONS = 20 advtrains.modpath = minetest.get_modpath("advtrains") --- Initialize internationalization (using ywang's poconvert) +-- Continue to provide poconvert for other mods that may depend on this advtrains.poconvert = dofile(advtrains.modpath.."/poconvert.lua") -advtrains.poconvert.from_flat("advtrains") + -- ask engine for translator instance, this will load the translation files advtrains.translate = core.get_translator("advtrains") diff --git a/advtrains/poconvert.lua b/advtrains/poconvert.lua index 2934a13..322acd3 100644 --- a/advtrains/poconvert.lua +++ b/advtrains/poconvert.lua @@ -153,7 +153,19 @@ local function convert_po_string(textdomain, str) return table.concat(st, "\n") end +local warn_mods = {} + +-- warn about poconvert deprecation +local function warn_poconvert() + local modname = core.get_current_modname() + if not warn_mods[modname] then + warn_mods[modname] = true + core.log("warning", modname .. ": poconvert is deprecated; consider using .po files directly") + end +end + local function convert_po_file(textdomain, inpath, outpath) + warn_poconvert() local f, err = io.open(inpath, "rb") assert(f, err) local str = convert_po_string(textdomain, f:read("*a")) @@ -164,6 +176,7 @@ end local function convert_flat_po_directory(textdomain, modpath) assert(textdomain, "No textdomain specified for po file conversion") + warn_poconvert() local mp = modpath or minetest.get_modpath(textdomain) assert(mp ~= nil, "No path to write for " .. textdomain) local popath = mp .. "/po" -- cgit v1.2.3