From 89f3991351185b365ccd10525e74d35d7bb2da46 Mon Sep 17 00:00:00 2001
From: Lars Müller <34514239+appgurueu@users.noreply.github.com>
Date: Sun, 30 May 2021 20:23:12 +0200
Subject: Fix base64 validation and add unittests (#10515)
Implement proper padding character checks
---
doc/client_lua_api.txt | 4 +++-
doc/lua_api.txt | 4 +++-
2 files changed, 6 insertions(+), 2 deletions(-)
(limited to 'doc')
diff --git a/doc/client_lua_api.txt b/doc/client_lua_api.txt
index 1e8015f7b..d239594f7 100644
--- a/doc/client_lua_api.txt
+++ b/doc/client_lua_api.txt
@@ -910,7 +910,9 @@ Call these functions only at load time!
* Example: `minetest.rgba(10, 20, 30, 40)`, returns `"#0A141E28"`
* `minetest.encode_base64(string)`: returns string encoded in base64
* Encodes a string in base64.
-* `minetest.decode_base64(string)`: returns string
+* `minetest.decode_base64(string)`: returns string or nil on failure
+ * Padding characters are only supported starting at version 5.4.0, where
+ 5.5.0 and newer perform proper checks.
* Decodes a string encoded in base64.
* `minetest.gettext(string)` : returns string
* look up the translation of a string in the gettext message catalog
diff --git a/doc/lua_api.txt b/doc/lua_api.txt
index 6c7ae0fb5..956919c89 100644
--- a/doc/lua_api.txt
+++ b/doc/lua_api.txt
@@ -5773,7 +5773,9 @@ Misc.
* Example: `minetest.rgba(10, 20, 30, 40)`, returns `"#0A141E28"`
* `minetest.encode_base64(string)`: returns string encoded in base64
* Encodes a string in base64.
-* `minetest.decode_base64(string)`: returns string or nil for invalid base64
+* `minetest.decode_base64(string)`: returns string or nil on failure
+ * Padding characters are only supported starting at version 5.4.0, where
+ 5.5.0 and newer perform proper checks.
* Decodes a string encoded in base64.
* `minetest.is_protected(pos, name)`: returns boolean
* Returning `true` restricts the player `name` from modifying (i.e. digging,
--
cgit v1.2.3
blob: 80c1949f940c34acb432e04f3e66800af8457a2e (
plain)
1
2
3
4
|
Checks: '-*,modernize-use-emplace,modernize-use-default-member-init,modernize-use-equals-delete,modernize-use-equals-default,modernize-return-braced-init-list,modernize-loop-convert,modernize-avoid-bind,misc-throw-by-value-catch-by-reference,misc-string-compare,misc-inefficient-algorithm,misc-inaccurate-erase,misc-incorrect-roundings,misc-unconventional-assign-operator,bugprone-suspicious-memset-usage,performance-*'
CheckOptions:
- key: modernize-use-default-member-init.UseAssignment
value: True
|