From a1459a9eac4eeb35a6c578a8b8f96393f87ed53d Mon Sep 17 00:00:00 2001 From: SmallJoker Date: Sun, 26 May 2019 09:54:23 +0200 Subject: Fix persistent ^[brighten after damage again (#5739) The old texture modifier is restored by passing `m_previous_texture_modifier`. Either copy it manually or let the function parameter do that. Victims so far: 8e0b80a Apr 2018 eb2bda7 May 2019 --- src/client/content_cao.h | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) (limited to 'src/client/content_cao.h') diff --git a/src/client/content_cao.h b/src/client/content_cao.h index 320607061..ca1518fb2 100644 --- a/src/client/content_cao.h +++ b/src/client/content_cao.h @@ -225,7 +225,9 @@ public: void updateTexturePos(); - void updateTextures(const std::string &modref); + // ffs this HAS TO BE a string copy! See #5739 if you think otherwise + // Reason: updateTextures(m_previous_texture_modifier); + void updateTextures(std::string mod); void updateAnimation(); -- cgit v1.2.3