From eda35100b6c6f7d9b01c257557147545b563dc74 Mon Sep 17 00:00:00 2001
From: Loïc Blot <nerzhul@users.noreply.github.com>
Date: Thu, 13 Dec 2018 20:18:54 +0100
Subject: Add an activeobject manager to hold active objects (#7939)

* Add an activeobject manager to hold active objects
* Add unittests
---
 src/unittest/test_clientactiveobjectmgr.cpp | 117 ++++++++++++++++++++++++++++
 1 file changed, 117 insertions(+)
 create mode 100644 src/unittest/test_clientactiveobjectmgr.cpp

(limited to 'src/unittest/test_clientactiveobjectmgr.cpp')

diff --git a/src/unittest/test_clientactiveobjectmgr.cpp b/src/unittest/test_clientactiveobjectmgr.cpp
new file mode 100644
index 000000000..4d2846c8d
--- /dev/null
+++ b/src/unittest/test_clientactiveobjectmgr.cpp
@@ -0,0 +1,117 @@
+/*
+Minetest
+Copyright (C) 2018 nerzhul, Loic Blot <loic.blot@unix-experience.fr>
+
+This program is free software; you can redistribute it and/or modify
+it under the terms of the GNU Lesser General Public License as published by
+the Free Software Foundation; either version 2.1 of the License, or
+(at your option) any later version.
+
+This program is distributed in the hope that it will be useful,
+but WITHOUT ANY WARRANTY; without even the implied warranty of
+MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+GNU Lesser General Public License for more details.
+
+You should have received a copy of the GNU Lesser General Public License along
+with this program; if not, write to the Free Software Foundation, Inc.,
+51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
+*/
+
+#include "client/activeobjectmgr.h"
+#include <algorithm>
+#include "test.h"
+
+#include "profiler.h"
+
+class TestClientActiveObject : public ClientActiveObject
+{
+public:
+	TestClientActiveObject() : ClientActiveObject(0, nullptr, nullptr) {}
+	~TestClientActiveObject() = default;
+	ActiveObjectType getType() const { return ACTIVEOBJECT_TYPE_TEST; }
+};
+
+class TestClientActiveObjectMgr : public TestBase
+{
+public:
+	TestClientActiveObjectMgr() { TestManager::registerTestModule(this); }
+	const char *getName() { return "TestClientActiveObjectMgr"; }
+
+	void runTests(IGameDef *gamedef);
+
+	void testFreeID();
+	void testRegisterObject();
+	void testRemoveObject();
+};
+
+static TestClientActiveObjectMgr g_test_instance;
+
+void TestClientActiveObjectMgr::runTests(IGameDef *gamedef)
+{
+	TEST(testFreeID);
+	TEST(testRegisterObject)
+	TEST(testRemoveObject)
+}
+
+////////////////////////////////////////////////////////////////////////////////
+
+void TestClientActiveObjectMgr::testFreeID()
+{
+	client::ActiveObjectMgr caomgr;
+	std::vector<u16> aoids;
+
+	u16 aoid = caomgr.getFreeId();
+	// Ensure it's not the same id
+	UASSERT(caomgr.getFreeId() != aoid);
+
+	aoids.push_back(aoid);
+
+	// Register basic objects, ensure we never found
+	for (u8 i = 0; i < UINT8_MAX; i++) {
+		// Register an object
+		auto tcao = new TestClientActiveObject();
+		caomgr.registerObject(tcao);
+		aoids.push_back(tcao->getId());
+
+		// Ensure next id is not in registered list
+		UASSERT(std::find(aoids.begin(), aoids.end(), caomgr.getFreeId()) ==
+				aoids.end());
+	}
+
+	caomgr.clear();
+}
+
+void TestClientActiveObjectMgr::testRegisterObject()
+{
+	client::ActiveObjectMgr caomgr;
+	auto tcao = new TestClientActiveObject();
+	UASSERT(caomgr.registerObject(tcao));
+
+	u16 id = tcao->getId();
+
+	auto tcaoToCompare = caomgr.getActiveObject(id);
+	UASSERT(tcaoToCompare->getId() == id);
+	UASSERT(tcaoToCompare == tcao);
+
+	tcao = new TestClientActiveObject();
+	UASSERT(caomgr.registerObject(tcao));
+	UASSERT(caomgr.getActiveObject(tcao->getId()) == tcao);
+	UASSERT(caomgr.getActiveObject(tcao->getId()) != tcaoToCompare);
+
+	caomgr.clear();
+}
+
+void TestClientActiveObjectMgr::testRemoveObject()
+{
+	client::ActiveObjectMgr caomgr;
+	auto tcao = new TestClientActiveObject();
+	UASSERT(caomgr.registerObject(tcao));
+
+	u16 id = tcao->getId();
+	UASSERT(caomgr.getActiveObject(id) != nullptr)
+
+	caomgr.removeObject(tcao->getId());
+	UASSERT(caomgr.getActiveObject(id) == nullptr)
+
+	caomgr.clear();
+}
-- 
cgit v1.2.3