From d38f6ebb9bb9ff201b3a1e19a8e6ad311dbe4972 Mon Sep 17 00:00:00 2001 From: sapier Date: Wed, 16 Jul 2014 20:01:00 +0200 Subject: Fix error handling on inconsistent client ready message Fix android makefile to provide a correct dummy githash if detection fails --- src/server.cpp | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) (limited to 'src') diff --git a/src/server.cpp b/src/server.cpp index 1e644ce6c..40857f84d 100644 --- a/src/server.cpp +++ b/src/server.cpp @@ -1732,14 +1732,20 @@ void Server::ProcessData(u8 *data, u32 datasize, u16 peer_id) if (playersao == NULL) { errorstream - << "TOSERVER_CLIENT_READY stage 2 client init failed for peer " + << "TOSERVER_CLIENT_READY stage 2 client init failed for peer_id: " << peer_id << std::endl; + m_con.DisconnectPeer(peer_id); return; } - if(datasize < 2+8) + if(datasize < 2+8) { + errorstream + << "TOSERVER_CLIENT_READY client sent inconsistent data, disconnecting peer_id: " + << peer_id << std::endl; + m_con.DisconnectPeer(peer_id); return; + } m_clients.setClientVersion( peer_id, -- cgit v1.2.3