aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authororwell96 <orwell@bleipb.de>2018-10-29 18:12:00 +0100
committerorwell96 <orwell@bleipb.de>2018-10-29 18:12:00 +0100
commit0ae0b6a768ebb33d3835875e3a3b5dc30379c92b (patch)
tree035d9b03f2c72cf51c104192fe4b6a8515f2e70f
parent9f6ae55e37141e8e446e6229132495e69b0e31ad (diff)
Fix signal_get_aspect()
Had a series of bugs as result, like auto-clearing IPs and not-working lzb
-rw-r--r--advtrains_interlocking/lzb.lua3
-rw-r--r--advtrains_interlocking/signal_api.lua5
2 files changed, 5 insertions, 3 deletions
diff --git a/advtrains_interlocking/lzb.lua b/advtrains_interlocking/lzb.lua
index 54b1a7a..77b115d 100644
--- a/advtrains_interlocking/lzb.lua
+++ b/advtrains_interlocking/lzb.lua
@@ -117,7 +117,6 @@ local function look_ahead(id, train)
idx = trav,
spd = lspd,
})
- -- TODO register aspect change callback!
end
end
end
@@ -126,6 +125,8 @@ local function look_ahead(id, train)
lzb.travspd = travspd
lzb.travwspd = travwspd
+ --train.debug = dump(lzb)
+
end
--[[
diff --git a/advtrains_interlocking/signal_api.lua b/advtrains_interlocking/signal_api.lua
index 9238587..021cbfd 100644
--- a/advtrains_interlocking/signal_api.lua
+++ b/advtrains_interlocking/signal_api.lua
@@ -287,7 +287,7 @@ function advtrains.interlocking.signal_get_supposed_aspect(pos)
end
-- Returns the actual aspect of the signal at position, as returned by the nodedef.
--- returns nil
+-- returns nil when there's no signal at the position
function advtrains.interlocking.signal_get_aspect(pos)
local node=advtrains.ndb.get_node(pos)
local ndef=minetest.registered_nodes[node.name]
@@ -295,8 +295,9 @@ function advtrains.interlocking.signal_get_aspect(pos)
local asp = ndef.advtrains.get_aspect(pos, node)
if not asp then asp = DANGER end
fillout_aspect(asp)
- return
+ return asp
end
+ return nil
end
local players_assign_ip = {}
com">This program is free software; you can redistribute it and/or modify it under the terms of the GNU Lesser General Public License as published by the Free Software Foundation; either version 2.1 of the License, or (at your option) any later version. This program is distributed in the hope that it will be useful, but WITHOUT ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU Lesser General Public License for more details. You should have received a copy of the GNU Lesser General Public License along with this program; if not, write to the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. */ #include "content_nodemeta.h" #include "nodemetadata.h" #include "nodetimer.h" #include "inventory.h" #include "log.h" #include "serialization.h" #include "util/serialize.h" #include "util/string.h" #include "constants.h" // MAP_BLOCKSIZE #include <sstream> #define NODEMETA_GENERIC 1 #define NODEMETA_SIGN 14 #define NODEMETA_CHEST 15 #define NODEMETA_FURNACE 16 #define NODEMETA_LOCKABLE_CHEST 17 // Returns true if node timer must be set static bool content_nodemeta_deserialize_legacy_body( std::istream &is, s16 id, NodeMetadata *meta) { meta->clear(); if(id == NODEMETA_GENERIC) // GenericNodeMetadata (0.4-dev) { meta->getInventory()->deSerialize(is); deSerializeLongString(is); // m_text deSerializeString(is); // m_owner meta->setString("infotext",deSerializeString(is)); meta->setString("formspec",deSerializeString(is)); readU8(is); // m_allow_text_input readU8(is); // m_allow_removal readU8(is); // m_enforce_owner int num_vars = readU32(is); for(int i=0; i<num_vars; i++){ std::string name = deSerializeString(is); std::string var = deSerializeLongString(is); meta->setString(name, var); } return false; } else if(id == NODEMETA_SIGN) // SignNodeMetadata { meta->setString("text", deSerializeString(is)); //meta->setString("infotext","\"${text}\""); meta->setString("infotext", std::string("\"") + meta->getString("text") + "\""); meta->setString("formspec","field[text;;${text}]"); return false; } else if(id == NODEMETA_CHEST) // ChestNodeMetadata { meta->getInventory()->deSerialize(is); // Rename inventory list "0" to "main" Inventory *inv = meta->getInventory(); if(!inv->getList("main") && inv->getList("0")){ inv->getList("0")->setName("main"); } assert(inv->getList("main") && !inv->getList("0")); meta->setString("formspec","size[8,9]" "list[current_name;main;0,0;8,4;]" "list[current_player;main;0,5;8,4;]"); return false; } else if(id == NODEMETA_LOCKABLE_CHEST) // LockingChestNodeMetadata { meta->setString("owner", deSerializeString(is)); meta->getInventory()->deSerialize(is); // Rename inventory list "0" to "main" Inventory *inv = meta->getInventory(); if(!inv->getList("main") && inv->getList("0")){ inv->getList("0")->setName("main"); } assert(inv->getList("main") && !inv->getList("0")); meta->setString("formspec","size[8,9]" "list[current_name;main;0,0;8,4;]" "list[current_player;main;0,5;8,4;]"); return false; } else if(id == NODEMETA_FURNACE) // FurnaceNodeMetadata { meta->getInventory()->deSerialize(is); int temp = 0; is>>temp; meta->setString("fuel_totaltime", ftos((float)temp/10)); temp = 0; is>>temp; meta->setString("fuel_time", ftos((float)temp/10)); temp = 0; is>>temp; //meta->setString("src_totaltime", ftos((float)temp/10)); temp = 0; is>>temp; meta->setString("src_time", ftos((float)temp/10)); meta->setString("formspec","size[8,9]" "list[current_name;fuel;2,3;1,1;]" "list[current_name;src;2,1;1,1;]" "list[current_name;dst;5,1;2,2;]" "list[current_player;main;0,5;8,4;]"); return true;