Fix segfault with invalid texture strings and minimap enabled - minetest.git

diff options

author	sfan5 <sfan5@live.de>	2021-02-14 11:28:02 +0100
committer	sfan5 <sfan5@live.de>	2021-02-14 11:28:02 +0100
commit	f018737b0646e0961a46a74765945d6039e47b88 (patch)
tree	eca346a9a9d49a37005ebd461ccd55636fe4fccb /po/sw
parent	375bcd65c1903957e3a640cefffcc8df164b78bd (diff)
download	minetest-f018737b0646e0961a46a74765945d6039e47b88.tar.gz minetest-f018737b0646e0961a46a74765945d6039e47b88.tar.bz2 minetest-f018737b0646e0961a46a74765945d6039e47b88.zip

Fix segfault with invalid texture strings and minimap enabled

closes #10949

Diffstat (limited to 'po/sw')

0 files changed, 0 insertions, 0 deletions

/* Minetest Copyright (C) 2013 celeron55, Perttu Ahola <celeron55@gmail.com> This program is free software; you can redistribute it and/or modify it under the terms of the GNU Lesser General Public License as published by the Free Software Foundation; either version 2.1 of the License, or (at your option) any later version. This program is distributed in the hope that it will be useful, but WITHOUT ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU Lesser General Public License for more details. You should have received a copy of the GNU Lesser General Public License along with this program; if not, write to the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. */ #include "object_properties.h" #include "irrlichttypes_bloated.h" #include "exceptions.h" #include "util/serialize.h" #include "util/basic_macros.h" #include <sstream> ObjectProperties::ObjectProperties(): hp_max(1), physical(false), collideWithObjects(true), weight(5), collisionbox(-0.5,-0.5,-0.5, 0.5,0.5,0.5), visual("sprite"), mesh(""), visual_size(1,1), spritediv(1,1), initial_sprite_basepos(0,0), is_visible(true), makes_footstep_sound(false), automatic_rotate(0), stepheight(0), automatic_face_movement_dir(false), automatic_face_movement_dir_offset(0.0), backface_culling(true), nametag(""), nametag_color(255, 255, 255, 255), automatic_face_movement_max_rotation_per_sec(-1) { textures.push_back("unknown_object.png"); colors.push_back(video::SColor(255,255,255,255)); } std::string ObjectProperties::dump() { std::ostringstream os(std::ios::binary); os<<"hp_max="<<hp_max; os<<", physical="<<physical; os<<", collideWithObjects="<<collideWithObjects; os<<", weight="<<weight; os<<", collisionbox="<<PP(collisionbox.MinEdge)<<","<<PP(collisionbox.MaxEdge); os<<", visual="<<visual; os<<", mesh="<<mesh; os<<", visual_size="<<PP2(visual_size); os<<", textures=["; for(u32 i=0; i<textures.size(); i++){ os<<"\""<<textures[i]<<"\" "; } os<<"]"; os<<", colors=["; for(u32 i=0; i<colors.size(); i++){ os<<"\""<<colors[i].getAlpha()<<","<<colors[i].getRed()<<","<<colors[i].getGreen()<<","<<colors[i].getBlue()<<"\" "; } os<<"]"; os<<", spritediv="<<PP2(spritediv); os<<", initial_sprite_basepos="<<PP2(initial_sprite_basepos); os<<", is_visible="<<is_visible; os<<", makes_footstep_sound="<<makes_footstep_sound; os<<", automatic_rotate="<<automatic_rotate; os<<", backface_culling="<<backface_culling; os << ", nametag=" << nametag; os << ", nametag_color=" << "\"" << nametag_color.getAlpha() << "," << nametag_color.getRed() << "," << nametag_color.getGreen() << "," << nametag_color.getBlue() << "\" "; return os.str(); } void ObjectProperties::serialize(std::ostream &os) const { writeU8(os, 1); // version writeS16(os, hp_max); writeU8(os, physical); writeF1000(os, weight); writeV3F1000(os, collisionbox.MinEdge); writeV3F1000(os, collisionbox.MaxEdge); os<<serializeString(visual); writeV2F1000(os, visual_size); writeU16(os, textures.size()); for(u32 i=0; i<textures.size(); i++){ os<<serializeString(textures[i]); } writeV2S16(os, spritediv); writeV2S16(os, initial_sprite_basepos); writeU8(os, is_visible); writeU8(os, makes_footstep_sound); writeF1000(os, automatic_rotate); // Added in protocol version 14 os<<serializeString(mesh); writeU16(os, colors.size()); for(u32 i=0; i<colors.size(); i++){ writeARGB8(os, colors[i]); } writeU8(os, collideWithObjects); writeF1000(os,stepheight); writeU8(os, automatic_face_movement_dir); writeF1000(os, automatic_face_movement_dir_offset); writeU8(os, backface_culling); os << serializeString(nametag); writeARGB8(os, nametag_color); writeF1000(os, automatic_face_movement_max_rotation_per_sec); os << serializeString(infotext); os << serializeString(wield_item); // Add stuff only at the bottom. // Never remove anything, because we don't want new versions of this } void ObjectProperties::deSerialize(std::istream &is) { int version = readU8(is); if(version == 1) { try{ hp_max = readS16(is); physical = readU8(is); weight = readF1000(is); collisionbox.MinEdge = readV3F1000(is); collisionbox.MaxEdge = readV3F1000(is); visual = deSerializeString(is); visual_size = readV2F1000(is); textures.clear(); u32 texture_count = readU16(is); for(u32 i=0; i<texture_count; i++){ textures.push_back(deSerializeString(is)); } spritediv = readV2S16(is); initial_sprite_basepos = readV2S16(is); is_visible = readU8(is); makes_footstep_sound = readU8(is); automatic_rotate = readF1000(is); mesh = deSerializeString(is); u32 color_count = readU16(is); for(u32 i=0; i<color_count; i++){ colors.push_back(readARGB8(is)); } collideWithObjects = readU8(is); stepheight = readF1000(is); automatic_face_movement_dir = readU8(is); automatic_face_movement_dir_offset = readF1000(is); backface_culling = readU8(is); nametag = deSerializeString(is); nametag_color = readARGB8(is); automatic_face_movement_max_rotation_per_sec = readF1000(is); infotext = deSerializeString(is); wield_item = deSerializeString(is); }catch(SerializationError &e){} } else { throw SerializationError("unsupported ObjectProperties version"); } }


context:
space:
mode: