diff options
| author | Loic Blot <loic.blot@unix-experience.fr> | 2017-01-11 22:48:14 +0100 |
|---|---|---|
| committer | Loïc Blot <nerzhul@users.noreply.github.com> | 2017-01-13 21:56:24 +0100 |
| commit | ef0aa7d5b543b6561e1b7292b2d0a0ac43add55d (patch) | |
| tree | f5c396ec87193c2a2ea4ef4c1672939dc506507a /src/content_sao.cpp | |
| parent | e2dd96b432f057cd8a3886314c78a79138a99c5e (diff) | |
| download | minetest-ef0aa7d5b543b6561e1b7292b2d0a0ac43add55d.tar.gz minetest-ef0aa7d5b543b6561e1b7292b2d0a0ac43add55d.tar.bz2 minetest-ef0aa7d5b543b6561e1b7292b2d0a0ac43add55d.zip | |
Optimize SAO getStaticData by using std::string pointer instead of return copy
Signed-off-by: Loic Blot <loic.blot@unix-experience.fr>
Diffstat (limited to 'src/content_sao.cpp')
| -rw-r--r-- | src/content_sao.cpp | 9 |
1 files changed, 4 insertions, 5 deletions
diff --git a/src/content_sao.cpp b/src/content_sao.cpp index 852e2d788..bf8282af4 100644 --- a/src/content_sao.cpp +++ b/src/content_sao.cpp @@ -521,7 +521,7 @@ std::string LuaEntitySAO::getClientInitializationData(u16 protocol_version) return os.str(); } -std::string LuaEntitySAO::getStaticData() const +void LuaEntitySAO::getStaticData(std::string *result) const { verbosestream<<FUNCTION_NAME<<std::endl; std::ostringstream os(std::ios::binary); @@ -543,7 +543,7 @@ std::string LuaEntitySAO::getStaticData() const writeV3F1000(os, m_velocity); // yaw writeF1000(os, m_yaw); - return os.str(); + *result = os.str(); } int LuaEntitySAO::punch(v3f dir, @@ -918,10 +918,9 @@ std::string PlayerSAO::getClientInitializationData(u16 protocol_version) return os.str(); } -std::string PlayerSAO::getStaticData() const +void PlayerSAO::getStaticData(std::string *result) const { - FATAL_ERROR("Deprecated function (?)"); - return ""; + FATAL_ERROR("Deprecated function"); } void PlayerSAO::step(float dtime, bool send_recommended) |