diff options
| author | est31 <MTest31@outlook.com> | 2015-06-20 03:20:06 +0200 |
|---|---|---|
| committer | est31 <MTest31@outlook.com> | 2015-06-20 03:37:30 +0200 |
| commit | dd91b3d6fbc3a0b4b18b36b14864d703213dd622 (patch) | |
| tree | 0c73f02ef3357f9557694d489a42df424fab51fc /src/genericobject.cpp | |
| parent | 40226e52747156cbdc5128a416480b226e498fff (diff) | |
| download | minetest-dd91b3d6fbc3a0b4b18b36b14864d703213dd622.tar.gz minetest-dd91b3d6fbc3a0b4b18b36b14864d703213dd622.tar.bz2 minetest-dd91b3d6fbc3a0b4b18b36b14864d703213dd622.zip | |
Generic CAO cleanups and renames for clarification
* Use enum for GENERIC_CMD_*
* Rename m_attachements to attachement_parent_ids (public member and clearer name)
* Rename GENERIC_CMD_SET_ATTACHMENT to GENERIC_CMD_ATTACH_TO
* USHRT_MAX + 1 buffer sizes to prevent overflows as @kahrl suggested
* Remove unneccessary m_id from GenericCAO (shadowing protected superclass member for no reason) as @kahrl suggested
Diffstat (limited to 'src/genericobject.cpp')
| -rw-r--r-- | src/genericobject.cpp | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/genericobject.cpp b/src/genericobject.cpp index 78dc7fa91..5daba55ed 100644 --- a/src/genericobject.cpp +++ b/src/genericobject.cpp @@ -161,7 +161,7 @@ std::string gob_cmd_update_attachment(int parent_id, std::string bone, v3f posit { std::ostringstream os(std::ios::binary); // command - writeU8(os, GENERIC_CMD_SET_ATTACHMENT); + writeU8(os, GENERIC_CMD_ATTACH_TO); // parameters writeS16(os, parent_id); os<<serializeString(bone); |