diff options
| author | Loïc Blot <nerzhul@users.noreply.github.com> | 2017-04-20 00:12:52 +0200 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2017-04-20 00:12:52 +0200 |
| commit | f98bbe193e0093aca8d8957cec82fdbd28639915 (patch) | |
| tree | 19879fbca595d4e8cddfa8d7d069b7f78016a713 /src/genericobject.cpp | |
| parent | f3fe62a0bf9e775b3e6e838f104ab605a2238792 (diff) | |
| download | minetest-f98bbe193e0093aca8d8957cec82fdbd28639915.tar.gz minetest-f98bbe193e0093aca8d8957cec82fdbd28639915.tar.bz2 minetest-f98bbe193e0093aca8d8957cec82fdbd28639915.zip | |
Fix various copy instead of const ref reported by cppcheck (part 3) (#5616)
* Also remove 2 non declared but defined functions
* Make some functions around const ref changes const
Diffstat (limited to 'src/genericobject.cpp')
| -rw-r--r-- | src/genericobject.cpp | 23 |
1 files changed, 13 insertions, 10 deletions
diff --git a/src/genericobject.cpp b/src/genericobject.cpp index 07d2445b4..58f4b997e 100644 --- a/src/genericobject.cpp +++ b/src/genericobject.cpp @@ -68,7 +68,7 @@ std::string gob_cmd_update_position( std::string gob_cmd_set_texture_mod(const std::string &mod) { std::ostringstream os(std::ios::binary); - // command + // command writeU8(os, GENERIC_CMD_SET_TEXTURE_MOD); // parameters os<<serializeString(mod); @@ -95,7 +95,7 @@ std::string gob_cmd_set_sprite( std::string gob_cmd_punched(s16 damage, s16 result_hp) { std::ostringstream os(std::ios::binary); - // command + // command writeU8(os, GENERIC_CMD_PUNCHED); // damage writeS16(os, damage); @@ -121,7 +121,7 @@ std::string gob_cmd_update_physics_override(float physics_override_speed, float float physics_override_gravity, bool sneak, bool sneak_glitch, bool new_move) { std::ostringstream os(std::ios::binary); - // command + // command writeU8(os, GENERIC_CMD_SET_PHYSICS_OVERRIDE); // parameters writeF1000(os, physics_override_speed); @@ -137,7 +137,7 @@ std::string gob_cmd_update_physics_override(float physics_override_speed, float std::string gob_cmd_update_animation(v2f frames, float frame_speed, float frame_blend, bool frame_loop) { std::ostringstream os(std::ios::binary); - // command + // command writeU8(os, GENERIC_CMD_SET_ANIMATION); // parameters writeV2F1000(os, frames); @@ -148,10 +148,11 @@ std::string gob_cmd_update_animation(v2f frames, float frame_speed, float frame_ return os.str(); } -std::string gob_cmd_update_bone_position(std::string bone, v3f position, v3f rotation) +std::string gob_cmd_update_bone_position(const std::string &bone, v3f position, + v3f rotation) { std::ostringstream os(std::ios::binary); - // command + // command writeU8(os, GENERIC_CMD_SET_BONE_POSITION); // parameters os<<serializeString(bone); @@ -160,10 +161,11 @@ std::string gob_cmd_update_bone_position(std::string bone, v3f position, v3f rot return os.str(); } -std::string gob_cmd_update_attachment(int parent_id, std::string bone, v3f position, v3f rotation) +std::string gob_cmd_update_attachment(int parent_id, const std::string &bone, + v3f position, v3f rotation) { std::ostringstream os(std::ios::binary); - // command + // command writeU8(os, GENERIC_CMD_ATTACH_TO); // parameters writeS16(os, parent_id); @@ -184,10 +186,11 @@ std::string gob_cmd_update_nametag_attributes(video::SColor color) return os.str(); } -std::string gob_cmd_update_infant(u16 id, u8 type, std::string client_initialization_data) +std::string gob_cmd_update_infant(u16 id, u8 type, + const std::string &client_initialization_data) { std::ostringstream os(std::ios::binary); - // command + // command writeU8(os, GENERIC_CMD_SPAWN_INFANT); // parameters writeU16(os, id); |