summaryrefslogtreecommitdiff
path: root/src/guiFormSpecMenu.h
diff options
context:
space:
mode:
authorLoïc Blot <nerzhul@users.noreply.github.com>2017-04-25 10:17:53 +0200
committerLoïc Blot <loic.blot@unix-experience.fr>2017-04-25 10:21:42 +0200
commita7e131f53e211ffbe38d34d23b33e13cc401f013 (patch)
treec615160a94df851752d62bfc2a4cf9f4d01f63ab /src/guiFormSpecMenu.h
parentaf9630962134346750f12c9f1856eae00e0dfe02 (diff)
downloadminetest-a7e131f53e211ffbe38d34d23b33e13cc401f013.tar.gz
minetest-a7e131f53e211ffbe38d34d23b33e13cc401f013.tar.bz2
minetest-a7e131f53e211ffbe38d34d23b33e13cc401f013.zip
Fix various points reported by cppcheck (#5656)
* Fix various performance issues reported by cppcheck + code style (CI) * Make CI happy with code style on master * guiFileSelectMenu: remove useless includes * some performance fixes pointed by cppcheck * remove some useless casts * TextDest: remove unused setFormSpec function * Fix various iterator post-increment reported by cppcheck
Diffstat (limited to 'src/guiFormSpecMenu.h')
-rw-r--r--src/guiFormSpecMenu.h2
1 files changed, 1 insertions, 1 deletions
diff --git a/src/guiFormSpecMenu.h b/src/guiFormSpecMenu.h
index e30565be8..af2d3f45e 100644
--- a/src/guiFormSpecMenu.h
+++ b/src/guiFormSpecMenu.h
@@ -69,7 +69,7 @@ public:
virtual ~IFormSource(){}
virtual std::string getForm() = 0;
// Fill in variables in field text
- virtual std::string resolveText(std::string str){ return str; }
+ virtual std::string resolveText(const std::string &str) { return str; }
};
class GUIFormSpecMenu : public GUIModalMenu