diff options
author | Loïc Blot <nerzhul@users.noreply.github.com> | 2017-04-19 23:02:07 +0200 |
---|---|---|
committer | GitHub <noreply@github.com> | 2017-04-19 23:02:07 +0200 |
commit | f3fe62a0bf9e775b3e6e838f104ab605a2238792 (patch) | |
tree | 1335fc9752d54924dd3a8f22e70d555fb54945c8 /src/inventory.h | |
parent | cfe0291b131630a7400fdcf46b720bd70d8d0fa0 (diff) | |
download | minetest-f3fe62a0bf9e775b3e6e838f104ab605a2238792.tar.gz minetest-f3fe62a0bf9e775b3e6e838f104ab605a2238792.tar.bz2 minetest-f3fe62a0bf9e775b3e6e838f104ab605a2238792.zip |
Fix various copy instead of const ref reported by cppcheck (#5615)
* Also remove InventoryList::peekItem unused function
* Fix some post increment to preincrement reported by cppcheck
Diffstat (limited to 'src/inventory.h')
-rw-r--r-- | src/inventory.h | 7 |
1 files changed, 2 insertions, 5 deletions
diff --git a/src/inventory.h b/src/inventory.h index fe1639728..a9fef3b05 100644 --- a/src/inventory.h +++ b/src/inventory.h @@ -173,7 +173,7 @@ struct ItemStack class InventoryList { public: - InventoryList(std::string name, u32 size, IItemDefManager *itemdef); + InventoryList(const std::string &name, u32 size, IItemDefManager *itemdef); ~InventoryList(); void clearItems(); void setSize(u32 newsize); @@ -239,9 +239,6 @@ public: // Returns empty item if couldn't take any. ItemStack takeItem(u32 i, u32 takecount); - // Similar to takeItem, but keeps the slot intact. - ItemStack peekItem(u32 i, u32 peekcount) const; - // Move an item to a different list (or a different stack in the same list) // count is the maximum number of items to move (0 for everything) // returns number of moved items @@ -254,8 +251,8 @@ public: private: std::vector<ItemStack> m_items; - u32 m_size, m_width; std::string m_name; + u32 m_size, m_width; IItemDefManager *m_itemdef; }; |