diff options
| author | Loïc Blot <nerzhul@users.noreply.github.com> | 2017-03-22 21:41:02 +0100 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2017-03-22 21:41:02 +0100 |
| commit | 072bbba69aa2528c309b76aaec288bdba52e119c (patch) | |
| tree | 60070fc33757aebdd52c666cdbd3de85fc2e673a /src/itemdef.h | |
| parent | 9efc5da0fb7d276deff55db6e4eb89d24ca72b5d (diff) | |
| download | minetest-072bbba69aa2528c309b76aaec288bdba52e119c.tar.gz minetest-072bbba69aa2528c309b76aaec288bdba52e119c.tar.bz2 minetest-072bbba69aa2528c309b76aaec288bdba52e119c.zip | |
Some performance optimizations (#5424)
* Some performance optimizations
This is globally removing some memory useless copy
* use a const ref return on std::string Settings::get to prevent data copy on getters which doesn't need to copy it
* pass some stack created strings to static const as they are not modified anywhere
* Camera: return nametags per const ref instead of a list pointer, we only need to read it
* INodeDefManager: getAll should be a result ref writer instead of a return copy
* INodeDefManager: getAlias should return a const std::string ref
* Minimap: unroll a Scolor creation in blitMinimapPixersToImageRadar to prvent many variable construct/destruct which are unneeded (we rewrite the content in the loop)
* CNodeDefManager::updateAliases: prevent a idef getall copy
* Profiler: constness
* rollback_interface: create real_name later, and use const ref
* MapBlockMesh updateFastFaceRow: unroll TileSpec next_tile, which has a cost of 1.8% CPU due to variable allocation/destruction,
* MapBlockMesh updateFastFaceRow: copy next_tile to tile only if it's a different tilespec
* MapBlockMesh updateFastFaceRow: use memcpy to copy next_lights to lights to do it in a single cpu operation
Diffstat (limited to 'src/itemdef.h')
| -rw-r--r-- | src/itemdef.h | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/src/itemdef.h b/src/itemdef.h index 2ade6116a..01ec4fa2f 100644 --- a/src/itemdef.h +++ b/src/itemdef.h @@ -100,9 +100,9 @@ public: // Get item definition virtual const ItemDefinition& get(const std::string &name) const=0; // Get alias definition - virtual std::string getAlias(const std::string &name) const=0; + virtual const std::string &getAlias(const std::string &name) const=0; // Get set of all defined item names and aliases - virtual std::set<std::string> getAll() const=0; + virtual void getAll(std::set<std::string> &result) const=0; // Check if item is known virtual bool isKnown(const std::string &name) const=0; #ifndef SERVER @@ -126,9 +126,9 @@ public: // Get item definition virtual const ItemDefinition& get(const std::string &name) const=0; // Get alias definition - virtual std::string getAlias(const std::string &name) const=0; + virtual const std::string &getAlias(const std::string &name) const=0; // Get set of all defined item names and aliases - virtual std::set<std::string> getAll() const=0; + virtual void getAll(std::set<std::string> &result) const=0; // Check if item is known virtual bool isKnown(const std::string &name) const=0; #ifndef SERVER |