summaryrefslogtreecommitdiff
path: root/src/mapgen
diff options
context:
space:
mode:
authorParamat <paramat@users.noreply.github.com>2019-07-20 01:03:52 +0100
committerGitHub <noreply@github.com>2019-07-20 01:03:52 +0100
commit76824bac9ff817d8072434997543464995b7e7e0 (patch)
tree736604aaa515492c7edc124f7d6611750918c83a /src/mapgen
parenta6f784835244111c90c05b6aae47092c2c5763a7 (diff)
downloadminetest-76824bac9ff817d8072434997543464995b7e7e0.tar.gz
minetest-76824bac9ff817d8072434997543464995b7e7e0.tar.bz2
minetest-76824bac9ff817d8072434997543464995b7e7e0.zip
Document the deprecation of hardcoded cave liquids (#8692)
Diffstat (limited to 'src/mapgen')
-rw-r--r--src/mapgen/cavegen.cpp5
-rw-r--r--src/mapgen/cavegen.h2
-rw-r--r--src/mapgen/mapgen.h2
3 files changed, 8 insertions, 1 deletions
diff --git a/src/mapgen/cavegen.cpp b/src/mapgen/cavegen.cpp
index 4fa3e009d..fa34b7273 100644
--- a/src/mapgen/cavegen.cpp
+++ b/src/mapgen/cavegen.cpp
@@ -29,6 +29,7 @@ with this program; if not, write to the Free Software Foundation, Inc.,
#include "mg_biome.h"
#include "cavegen.h"
+// TODO Remove this. Cave liquids are now defined and located using biome definitions
static NoiseParams nparams_caveliquids(0, 1, v3f(150.0, 150.0, 150.0), 776, 3, 0.6, 2.0);
@@ -526,7 +527,9 @@ void CavesRandomWalk::carveRoute(v3f vec, float f, bool randomize_xz)
if (use_biome_liquid) {
liquidnode = c_biome_liquid;
} else {
- // If cave liquid not defined by biome, fallback to old hardcoded behaviour
+ // TODO remove this. Cave liquids are now defined and located using biome
+ // definitions.
+ // If cave liquid not defined by biome, fallback to old hardcoded behaviour.
float nval = NoisePerlin3D(np_caveliquids, startp.X,
startp.Y, startp.Z, seed);
liquidnode = (nval < 0.40f && node_max.Y < lava_depth) ?
diff --git a/src/mapgen/cavegen.h b/src/mapgen/cavegen.h
index f5234a671..3f1730ddb 100644
--- a/src/mapgen/cavegen.h
+++ b/src/mapgen/cavegen.h
@@ -119,6 +119,8 @@ public:
// configurable parameters
s32 seed;
int water_level;
+ // TODO 'lava_depth' and 'np_caveliquids' are deprecated and should be removed.
+ // Cave liquids are now defined and located using biome definitions.
int lava_depth;
NoiseParams *np_caveliquids;
diff --git a/src/mapgen/mapgen.h b/src/mapgen/mapgen.h
index f98c3f377..4740c424e 100644
--- a/src/mapgen/mapgen.h
+++ b/src/mapgen/mapgen.h
@@ -278,5 +278,7 @@ protected:
float cavern_limit;
float cavern_taper;
float cavern_threshold;
+ // TODO 'lava_depth' is deprecated and should be removed. Cave liquids are
+ // now defined and located using biome definitions.
int lava_depth;
};