diff options
| author | Loïc Blot <nerzhul@users.noreply.github.com> | 2017-04-21 10:06:08 +0200 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2017-04-21 10:06:08 +0200 |
| commit | 370354cc87937bbfb6f24aa062966af8e039cec0 (patch) | |
| tree | e0400c3b3c63d3e8e8b22c81e40a9cabe2d1b5b1 /src/network | |
| parent | de5ecc9fa31d557e2d0ca638b1c98435707046b9 (diff) | |
| download | minetest-370354cc87937bbfb6f24aa062966af8e039cec0.tar.gz minetest-370354cc87937bbfb6f24aa062966af8e039cec0.tar.bz2 minetest-370354cc87937bbfb6f24aa062966af8e039cec0.zip | |
Fix various performance issues reported by cppcheck (#5628)
* Also remove 1 non declared but defined functions
Diffstat (limited to 'src/network')
| -rw-r--r-- | src/network/connection.cpp | 5 | ||||
| -rw-r--r-- | src/network/connection.h | 4 |
2 files changed, 4 insertions, 5 deletions
diff --git a/src/network/connection.cpp b/src/network/connection.cpp index e11b4a953..f9a4821a6 100644 --- a/src/network/connection.cpp +++ b/src/network/connection.cpp @@ -930,7 +930,7 @@ void Peer::DecUseCount() delete this; } -void Peer::RTTStatistics(float rtt, std::string profiler_id, +void Peer::RTTStatistics(float rtt, const std::string &profiler_id, unsigned int num_samples) { if (m_last_rtt > 0) { @@ -969,8 +969,7 @@ void Peer::RTTStatistics(float rtt, std::string profiler_id, m_rtt.jitter_avg = m_rtt.jitter_avg * (num_samples/(num_samples-1)) + jitter * (1/num_samples); - if (profiler_id != "") - { + if (profiler_id != "") { g_profiler->graphAdd(profiler_id + "_rtt", rtt); g_profiler->graphAdd(profiler_id + "_jitter", jitter); } diff --git a/src/network/connection.h b/src/network/connection.h index 7ba0d086e..dc86d2293 100644 --- a/src/network/connection.h +++ b/src/network/connection.h @@ -732,8 +732,8 @@ class Peer { virtual void reportRTT(float rtt) {}; void RTTStatistics(float rtt, - std::string profiler_id="", - unsigned int num_samples=1000); + const std::string &profiler_id = "", + unsigned int num_samples = 1000); bool IncUseCount(); void DecUseCount(); |