diff options
| author | Loïc Blot <nerzhul@users.noreply.github.com> | 2017-03-22 21:41:02 +0100 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2017-03-22 21:41:02 +0100 |
| commit | 072bbba69aa2528c309b76aaec288bdba52e119c (patch) | |
| tree | 60070fc33757aebdd52c666cdbd3de85fc2e673a /src/nodedef.cpp | |
| parent | 9efc5da0fb7d276deff55db6e4eb89d24ca72b5d (diff) | |
| download | minetest-072bbba69aa2528c309b76aaec288bdba52e119c.tar.gz minetest-072bbba69aa2528c309b76aaec288bdba52e119c.tar.bz2 minetest-072bbba69aa2528c309b76aaec288bdba52e119c.zip | |
Some performance optimizations (#5424)
* Some performance optimizations
This is globally removing some memory useless copy
* use a const ref return on std::string Settings::get to prevent data copy on getters which doesn't need to copy it
* pass some stack created strings to static const as they are not modified anywhere
* Camera: return nametags per const ref instead of a list pointer, we only need to read it
* INodeDefManager: getAll should be a result ref writer instead of a return copy
* INodeDefManager: getAlias should return a const std::string ref
* Minimap: unroll a Scolor creation in blitMinimapPixersToImageRadar to prvent many variable construct/destruct which are unneeded (we rewrite the content in the loop)
* CNodeDefManager::updateAliases: prevent a idef getall copy
* Profiler: constness
* rollback_interface: create real_name later, and use const ref
* MapBlockMesh updateFastFaceRow: unroll TileSpec next_tile, which has a cost of 1.8% CPU due to variable allocation/destruction,
* MapBlockMesh updateFastFaceRow: copy next_tile to tile only if it's a different tilespec
* MapBlockMesh updateFastFaceRow: use memcpy to copy next_lights to lights to do it in a single cpu operation
Diffstat (limited to 'src/nodedef.cpp')
| -rw-r--r-- | src/nodedef.cpp | 9 |
1 files changed, 5 insertions, 4 deletions
diff --git a/src/nodedef.cpp b/src/nodedef.cpp index 3532eea1e..2745a45e8 100644 --- a/src/nodedef.cpp +++ b/src/nodedef.cpp @@ -1332,12 +1332,13 @@ void CNodeDefManager::removeNode(const std::string &name) void CNodeDefManager::updateAliases(IItemDefManager *idef) { - std::set<std::string> all = idef->getAll(); + std::set<std::string> all; + idef->getAll(all); m_name_id_mapping_with_aliases.clear(); - for (std::set<std::string>::iterator + for (std::set<std::string>::const_iterator i = all.begin(); i != all.end(); ++i) { - std::string name = *i; - std::string convert_to = idef->getAlias(name); + const std::string &name = *i; + const std::string &convert_to = idef->getAlias(name); content_t id; if (m_name_id_mapping.getId(convert_to, id)) { m_name_id_mapping_with_aliases.insert( |