Fix find_nodes_in_area misbehaving with out-of-map coordinates (#11770) - minetest.git

diff options

author	sfan5 <sfan5@live.de>	2021-11-26 19:32:41 +0100
committer	GitHub <noreply@github.com>	2021-11-26 19:32:41 +0100
commit	87ab97da2ace31fdb46a88a0901ec664dd666feb (patch)
tree	71990e03cc72a8780e76a16e9c33cf348c7f05d0 /src/remoteplayer.h
parent	b9051386ae296a6112383725bc8bfcd96dc9a226 (diff)
download	minetest-87ab97da2ace31fdb46a88a0901ec664dd666feb.tar.gz minetest-87ab97da2ace31fdb46a88a0901ec664dd666feb.tar.bz2 minetest-87ab97da2ace31fdb46a88a0901ec664dd666feb.zip

Fix find_nodes_in_area misbehaving with out-of-map coordinates (#11770)

This ensures that no overflows (side-effects) happen within the find_nodes_in_area function by limiting coordinates like done in the map generation code.

Diffstat (limited to 'src/remoteplayer.h')

0 files changed, 0 insertions, 0 deletions

/* Minetest Copyright (C) 2013 celeron55, Perttu Ahola <celeron55@gmail.com> Copyright (C) 2017-8 rubenwardy <rw@rubenwardy.com> This program is free software; you can redistribute it and/or modify it under the terms of the GNU Lesser General Public License as published by the Free Software Foundation; either version 2.1 of the License, or (at your option) any later version. This program is distributed in the hope that it will be useful, but WITHOUT ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU Lesser General Public License for more details. You should have received a copy of the GNU Lesser General Public License along with this program; if not, write to the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. */ #include "lua_api/l_playermeta.h" #include "lua_api/l_internal.h" #include "common/c_content.h" /* PlayerMetaRef */ PlayerMetaRef *PlayerMetaRef::checkobject(lua_State *L, int narg) { luaL_checktype(L, narg, LUA_TUSERDATA); void *ud = luaL_checkudata(L, narg, className); if (!ud) luaL_typerror(L, narg, className); return *(PlayerMetaRef **)ud; // unbox pointer } Metadata *PlayerMetaRef::getmeta(bool auto_create) { return metadata; } void PlayerMetaRef::clearMeta() { metadata->clear(); } void PlayerMetaRef::reportMetadataChange(const std::string *name) { // TODO } // garbage collector int PlayerMetaRef::gc_object(lua_State *L) { PlayerMetaRef *o = *(PlayerMetaRef **)(lua_touserdata(L, 1)); delete o; return 0; } // Creates an PlayerMetaRef and leaves it on top of stack // Not callable from Lua; all references are created on the C side. void PlayerMetaRef::create(lua_State *L, Metadata *metadata) { PlayerMetaRef *o = new PlayerMetaRef(metadata); *(void **)(lua_newuserdata(L, sizeof(void *))) = o; luaL_getmetatable(L, className); lua_setmetatable(L, -2); } void PlayerMetaRef::Register(lua_State *L) { lua_newtable(L); int methodtable = lua_gettop(L); luaL_newmetatable(L, className); int metatable = lua_gettop(L); lua_pushliteral(L, "__metatable"); lua_pushvalue(L, methodtable); lua_settable(L, metatable); // hide metatable from Lua getmetatable() lua_pushliteral(L, "metadata_class"); lua_pushlstring(L, className, strlen(className)); lua_settable(L, metatable); lua_pushliteral(L, "__index"); lua_pushvalue(L, methodtable); lua_settable(L, metatable); lua_pushliteral(L, "__gc"); lua_pushcfunction(L, gc_object); lua_settable(L, metatable); lua_pushliteral(L, "__eq"); lua_pushcfunction(L, l_equals); lua_settable(L, metatable); lua_pop(L, 1); // drop metatable luaL_openlib(L, 0, methods, 0); lua_pop(L, 1); // Cannot be created from Lua // lua_register(L, className, create_object); } // clang-format off const char PlayerMetaRef::className[] = "PlayerMetaRef"; const luaL_Reg PlayerMetaRef::methods[] = { luamethod(MetaDataRef, contains), luamethod(MetaDataRef, get), luamethod(MetaDataRef, get_string), luamethod(MetaDataRef, set_string), luamethod(MetaDataRef, get_int), luamethod(MetaDataRef, set_int), luamethod(MetaDataRef, get_float), luamethod(MetaDataRef, set_float), luamethod(MetaDataRef, to_table), luamethod(MetaDataRef, from_table), luamethod(MetaDataRef, equals), {0,0} }; // clang-format on


context:
space:
mode: