diff options
author | Loic Blot <loic.blot@unix-experience.fr> | 2015-02-15 17:30:38 +0100 |
---|---|---|
committer | Loic Blot <loic.blot@unix-experience.fr> | 2015-02-16 11:27:44 +0100 |
commit | 7c8793cbea1ea83109b7d9d6974d3f6991efcec8 (patch) | |
tree | 3a1c54acd3ee11fd73e11e81e2b83f917488a379 /src/script | |
parent | ed04e8e9e407f0dd57fa83a9732b3a3968cb80e0 (diff) | |
download | minetest-7c8793cbea1ea83109b7d9d6974d3f6991efcec8.tar.gz minetest-7c8793cbea1ea83109b7d9d6974d3f6991efcec8.tar.bz2 minetest-7c8793cbea1ea83109b7d9d6974d3f6991efcec8.zip |
Performance Improvement: Use a cache which caches result for getFacePositions.
This greatly reduce the number of std::list generated by caching the result, which is always constant for each radius selected.
In the callgrind map, you will see original:
* 3.3M calls to std::list for 9700 calls to getFacePositions
In the modified version, you will see:
* 3.3K calls to std::list for 6900 call to getFacePositions
Callgrind map is here: #2321
it's a huge performance improvement to l_find_node_near
Diffstat (limited to 'src/script')
-rw-r--r-- | src/script/lua_api/l_env.cpp | 5 |
1 files changed, 2 insertions, 3 deletions
diff --git a/src/script/lua_api/l_env.cpp b/src/script/lua_api/l_env.cpp index cd5d253ac..2445803d7 100644 --- a/src/script/lua_api/l_env.cpp +++ b/src/script/lua_api/l_env.cpp @@ -530,9 +530,8 @@ int ModApiEnvMod::l_find_node_near(lua_State *L) } for(int d=1; d<=radius; d++){ - std::list<v3s16> list; - getFacePositions(list, d); - for(std::list<v3s16>::iterator i = list.begin(); + std::vector<v3s16> list = FacePositionCache::getFacePositions(d); + for(std::vector<v3s16>::iterator i = list.begin(); i != list.end(); ++i){ v3s16 p = pos + (*i); content_t c = env->getMap().getNodeNoEx(p).getContent(); |