diff options
author | sofar <sofar+github@foo-projects.org> | 2019-03-04 23:11:13 -0800 |
---|---|---|
committer | Loïc Blot <nerzhul@users.noreply.github.com> | 2019-03-05 08:11:13 +0100 |
commit | 61e5fbab721898a431b15a5a7e24efb58cd80eb4 (patch) | |
tree | c6a8fa1193434c142cd6dd688228a41bcc32a525 /src/unittest/test_gameui.cpp | |
parent | 51662dabb4ba38ea1ec027d907fb2d5f4e0412ad (diff) | |
download | minetest-61e5fbab721898a431b15a5a7e24efb58cd80eb4.tar.gz minetest-61e5fbab721898a431b15a5a7e24efb58cd80eb4.tar.bz2 minetest-61e5fbab721898a431b15a5a7e24efb58cd80eb4.zip |
getS16NoEx() returns true unless syntactical error in conf. (#8304)
The getS16NoEx() handler will return true unless there is a
`[num_emerge_threads]` line in the `minetest.conf` at which
point the excption handler part is reached. Due to the fact that
`defaultsettings.cpp` has a default value set for this setting,
that never will happen.
Because of this, the code will never check the number of threads on
the system, and keep `nthreads = 0`. If that happens, the value is
changed to `1` and only 1 emerge thread will be used.
The default should be set to `1` instead, due to the potential unsafe
consequences for the standard sqlite map files, but that should be a
separate commit that also adds documentation for that setting. This
commit focuses on removing this `hiding` bug instead.
Diffstat (limited to 'src/unittest/test_gameui.cpp')
0 files changed, 0 insertions, 0 deletions