diff options
| author | sofar <sofar+github@foo-projects.org> | 2019-03-04 23:11:13 -0800 |
|---|---|---|
| committer | rubenwardy <rw@rubenwardy.com> | 2019-03-11 22:07:19 +0000 |
| commit | 19825d853e6f30685f367e99e206327a6bcf14a2 (patch) | |
| tree | 9630e6ad6fcecf6070136837647e74dc40b46f21 /src/unittest/test_modchannels.cpp | |
| parent | d8ece2e3e951e070b37f670bd910d24855be5262 (diff) | |
| download | minetest-19825d853e6f30685f367e99e206327a6bcf14a2.tar.gz minetest-19825d853e6f30685f367e99e206327a6bcf14a2.tar.bz2 minetest-19825d853e6f30685f367e99e206327a6bcf14a2.zip | |
getS16NoEx() returns true unless syntactical error in conf. (#8304)
The getS16NoEx() handler will return true unless there is a
`[num_emerge_threads]` line in the `minetest.conf` at which
point the excption handler part is reached. Due to the fact that
`defaultsettings.cpp` has a default value set for this setting,
that never will happen.
Because of this, the code will never check the number of threads on
the system, and keep `nthreads = 0`. If that happens, the value is
changed to `1` and only 1 emerge thread will be used.
The default should be set to `1` instead, due to the potential unsafe
consequences for the standard sqlite map files, but that should be a
separate commit that also adds documentation for that setting. This
commit focuses on removing this `hiding` bug instead.
Diffstat (limited to 'src/unittest/test_modchannels.cpp')
0 files changed, 0 insertions, 0 deletions