GameUI refactor (part 1/X): GameUI object creation + GameUIFlags move to GameUI

Game class is too huge and has too specialization on various subjects, like UI, formspecs, client, renderer. Start to move UI related things to GameUI object and cleanup them

Other improvements:
* updateChat: more performance on error messages by remove string copies
* Initialize all game class members in definition instead of constructor (with nullptr instead of NULL)
* Drop unused Client::show{GameChat,GameHud,Profiler,GameFog}
* Add GameUI unittests

2 files changed, 61 insertions, 0 deletions

diff --git a/src/unittest/CMakeLists.txt b/src/unittest/CMakeLists.txt
index f56560666..56132d9c3 100644
--- a/src/unittest/CMakeLists.txt
+++ b/src/unittest/CMakeLists.txt
@@ -29,5 +29,6 @@ set (UNITTEST_SRCS
 	PARENT_SCOPE)
 
 set (UNITTEST_CLIENT_SRCS
+	${CMAKE_CURRENT_SOURCE_DIR}/test_gameui.cpp
 	${CMAKE_CURRENT_SOURCE_DIR}/test_keycode.cpp
 	PARENT_SCOPE)
diff --git a/src/unittest/test_gameui.cpp b/src/unittest/test_gameui.cpp
new file mode 100644
index 000000000..56f44ed87
--- /dev/null
+++ b/src/unittest/test_gameui.cpp
@@ -0,0 +1,60 @@
+/*
+Minetest
+Copyright (C) 2018 nerzhul, Loic BLOT <loic.blot@unix-experience.fr>
+
+This program is free software; you can redistribute it and/or modify
+it under the terms of the GNU Lesser General Public License as published by
+the Free Software Foundation; either version 2.1 of the License, or
+(at your option) any later version.
+
+This program is distributed in the hope that it will be useful,
+but WITHOUT ANY WARRANTY; without even the implied warranty of
+MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+GNU Lesser General Public License for more details.
+
+You should have received a copy of the GNU Lesser General Public License along
+with this program; if not, write to the Free Software Foundation, Inc.,
+51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
+*/
+
+#include "test.h"
+
+#include "client/gameui.h"
+
+class TestGameUI : public TestBase
+{
+public:
+	TestGameUI() { TestManager::registerTestModule(this); }
+	const char *getName() { return "TestGameUI"; }
+
+	void runTests(IGameDef *gamedef);
+
+	void testInit();
+	void testFlagSetters();
+};
+
+static TestGameUI g_test_instance;
+
+void TestGameUI::runTests(IGameDef *gamedef)
+{
+	TEST(testInit);
+	TEST(testFlagSetters);
+}
+
+void TestGameUI::testInit()
+{
+	GameUI gui{};
+	gui.initFlags();
+	UASSERT(gui.getFlags().show_chat)
+	UASSERT(gui.getFlags().show_hud)
+}
+
+void TestGameUI::testFlagSetters()
+{
+	GameUI gui;
+	gui.showMinimap(true);
+	UASSERT(gui.getFlags().show_minimap);
+
+	gui.showMinimap(false);
+	UASSERT(!gui.getFlags().show_minimap);
+}