diff options
| author | Tanavit <tanavit@posto.ovh> | 2025-04-20 09:52:04 +0200 |
|---|---|---|
| committer | orwell <orwell@bleipb.de> | 2025-05-05 21:06:33 +0200 |
| commit | d4835199f9fe1a605995e2842bd984a0bbc49ba7 (patch) | |
| tree | 5d8caae8b09fc04af6596b7d14bbf2b03ab0472e | |
| parent | 950ac381214883505206e847700fbafc70973c52 (diff) | |
| download | advtrains-d4835199f9fe1a605995e2842bd984a0bbc49ba7.tar.gz advtrains-d4835199f9fe1a605995e2842bd984a0bbc49ba7.tar.bz2 advtrains-d4835199f9fe1a605995e2842bd984a0bbc49ba7.zip | |
Stoprail configuration form translation bug correction
The implementation of the translation of the doors opening side in the stoprail
configuration form (commit c08896f) introduced a bug locking the opening doors
side selection dropdown box to "Closed".
This commit corrects this bug by use of the numerical index (1,2,3) of the side
selection instead of its litteral value ("Left","Right","Closed" or their translations).
| -rw-r--r-- | advtrains_line_automation/stoprail.lua | 7 |
1 files changed, 4 insertions, 3 deletions
diff --git a/advtrains_line_automation/stoprail.lua b/advtrains_line_automation/stoprail.lua index 89f4a09..aa8dfdd 100644 --- a/advtrains_line_automation/stoprail.lua +++ b/advtrains_line_automation/stoprail.lua @@ -24,7 +24,8 @@ local function updatemeta(pos) end local door_dropdown = {L=1, R=2, C=3} -local door_dropdown_rev = {Right="R", Left="L", Closed="C"} +--local door_dropdown_rev = {Right="R", Left="L", Closed="C"} -- Code review : why are the value in an order different than the one in the dropdown box ? +local door_dropdown_code = {"L", "R", "C"} -- switch to numerical index of selection : for conversion of the numerical index in the opening side selection dropdown box to the internal codification local function show_stoprailform(pos, player) local pe = advtrains.encode_pos(pos) @@ -60,7 +61,7 @@ local function show_stoprailform(pos, player) form = form.."field[4.30,2.0;1.75,1;track;"..S("Track")..";"..minetest.formspec_escape(stdata.track).."]" form = form.."field[6.05,2.0;1.75,1;wait;"..S("Stop Time")..";"..stdata.wait.."]" form = form.."label[0.5,2.6;"..S("Door Side").."]" - form = form.."dropdown[0.51,3.0;2;doors;"..S("Left")..","..S("Right")..","..S("Closed")..";"..door_dropdown[stdata.doors].."]" + form = form.."dropdown[0.51,3.0;2;doors;"..S("Left")..","..S("Right")..","..S("Closed")..";"..door_dropdown[stdata.doors]..";true]" -- switch to numerical index of the selection form = form.."checkbox[3.00,2.4;reverse;"..S("Reverse train")..";"..(stdata.reverse and "true" or "false").."]" form = form.."checkbox[3.00,2.8;kick;"..S("Kick out passengers")..";"..(stdata.kick and "true" or "false").."]" form = form.."checkbox[3.00,3.2;waitsig;"..S("Wait for signal to clear")..";"..(stdata.waitsig and "true" or "false").."]" @@ -120,7 +121,7 @@ minetest.register_on_player_receive_fields(function(player, formname, fields) -- dropdowns if fields.doors then - stdata.doors = door_dropdown_rev[fields.doors] or "C" + stdata.doors = door_dropdown_code[tonumber(fields.doors)] or "C" -- switch to numerical index of selection; attention : fields.doors is string typed, needed to be converted to an integer typed index in door_dropdown_code table end if fields.track then |